Source/core/layout/LayoutBox.cpp - Issue 1159773005: Handle border-image with fill and zero-width borders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.cpp

Issue 1159773005: Handle border-image with fill and zero-width borders (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove newly added but flaky test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/borders/border-image-fill-no-border-width-expected.html ('K') | « LayoutTests/fast/borders/border-image-fill-no-border-width-expected.html ('k') | Source/core/layout/LayoutBoxModelObject.cpp » ('j') | Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBox.cpp

diff --git a/Source/core/layout/LayoutBox.cpp b/Source/core/layout/LayoutBox.cpp

index cea21096536c19972e910b5159826c6ef4431a8d..293c9045fdceb05728450d29130c8322e1e8a477 100644

--- a/Source/core/layout/LayoutBox.cpp

+++ b/Source/core/layout/LayoutBox.cpp

@@ -4768,7 +4768,7 @@ bool LayoutBox::mustInvalidateBackgroundOrBorderPaintOnWidthChange() const

return true;

// Our fill layers are ok. Let's check border.

- if (style()->hasBorder() && canRenderBorderImage())

+ if (style()->hasBorderDecoration() && canRenderBorderImage())

return true;

return false;

@@ -4787,7 +4787,7 @@ bool LayoutBox::mustInvalidateBackgroundOrBorderPaintOnHeightChange() const

return true;

// Our fill layers are ok. Let's check border.

- if (style()->hasBorder() && canRenderBorderImage())

+ if (style()->hasBorderDecoration() && canRenderBorderImage())

return true;

return false;

@@ -4795,7 +4795,7 @@ bool LayoutBox::mustInvalidateBackgroundOrBorderPaintOnHeightChange() const

bool LayoutBox::canRenderBorderImage() const

{

- if (!style()->hasBorder())

+ if (!style()->hasBorderDecoration())

return false;

StyleImage* borderImage = style()->borderImage().image();