Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: Source/core/layout/LayoutObject.cpp

Issue 1159773005: Handle border-image with fill and zero-width borders (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.cpp ('k') | Source/core/paint/BoxDecorationData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
688 curr = curr->parent(); 688 curr = curr->parent();
689 } 689 }
690 } 690 }
691 return nullptr; 691 return nullptr;
692 } 692 }
693 693
694 // FIXME: This could be used when changing the size of a layoutObject without ch ildren to skip some invalidations. 694 // FIXME: This could be used when changing the size of a layoutObject without ch ildren to skip some invalidations.
695 // FIXME: This is incorrect for document element. Remove this when we enable sli mming paint. 695 // FIXME: This is incorrect for document element. Remove this when we enable sli mming paint.
696 static inline bool layoutObjectHasNoBoxEffectObsolete(const LayoutObject& object ) 696 static inline bool layoutObjectHasNoBoxEffectObsolete(const LayoutObject& object )
697 { 697 {
698 return !object.style()->hasVisualOverflowingEffect() && !object.style()->has Border() && !object.style()->hasBackground(); 698 return !object.style()->hasVisualOverflowingEffect() && !object.style()->has BorderDecoration() && !object.style()->hasBackground();
699 } 699 }
700 700
701 bool LayoutObject::skipInvalidationWhenLaidOutChildren() const 701 bool LayoutObject::skipInvalidationWhenLaidOutChildren() const
702 { 702 {
703 if (!neededLayoutBecauseOfChildren()) 703 if (!neededLayoutBecauseOfChildren())
704 return false; 704 return false;
705 705
706 // SVG layoutObjects need to be invalidated when their children are laid out . 706 // SVG layoutObjects need to be invalidated when their children are laid out .
707 // LayoutBlocks with line boxes are responsible to invalidate them so we can 't ignore them. 707 // LayoutBlocks with line boxes are responsible to invalidate them so we can 't ignore them.
708 if (isSVG() || (isLayoutBlockFlow() && toLayoutBlockFlow(this)->firstLineBox ())) 708 if (isSVG() || (isLayoutBlockFlow() && toLayoutBlockFlow(this)->firstLineBox ()))
(...skipping 2596 matching lines...) Expand 10 before | Expand all | Expand 10 after
3305 const blink::LayoutObject* root = object1; 3305 const blink::LayoutObject* root = object1;
3306 while (root->parent()) 3306 while (root->parent())
3307 root = root->parent(); 3307 root = root->parent();
3308 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3308 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3309 } else { 3309 } else {
3310 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3310 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3311 } 3311 }
3312 } 3312 }
3313 3313
3314 #endif 3314 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.cpp ('k') | Source/core/paint/BoxDecorationData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698