Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159763004: SkPDF: with opaque draws, treat SRC mode as SRC_OVER (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
tomhudson, *reed1
CC:
reviews_skia.org, Vitaly Buka (NO REVIEWS)
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: with opaque draws, treat SRC mode as SRC_OVER BUG=473572 Committed: https://skia.googlesource.com/skia/+/a681433d42323d6d48e1aa3cb2ef97fb9d958d93

Patch Set 1 : 2015-05-26 (Tuesday) 12:06:19 EDT #

Total comments: 2

Patch Set 2 : unit test comments, clarity #

Patch Set 3 : function #

Patch Set 4 : unify with blitter code #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -74 lines) Patch
M gyp/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 2 3 3 chunks +5 lines, -60 lines 0 comments Download
A src/core/SkXfermodeInterpretation.h View 1 2 3 1 chunk +22 lines, -0 lines 1 comment Download
A src/core/SkXfermodeInterpretation.cpp View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 10 chunks +67 lines, -14 lines 0 comments Download
A tests/skpdf_opaquesrcmodetosrcover.cpp View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159763004/1
5 years, 7 months ago (2015-05-26 16:04:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/1276)
5 years, 7 months ago (2015-05-26 16:05:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159763004/20001
5 years, 7 months ago (2015-05-26 16:06:50 UTC) #7
hal.canary
PTAL
5 years, 7 months ago (2015-05-26 16:08:18 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-26 16:12:42 UTC) #11
tomhudson
lgtm It'd be nice if the test was more self-explanatory.
5 years, 7 months ago (2015-05-26 16:17:40 UTC) #12
reed1
can we do code-sharing w/ interpret_xfermode in SkBlitter.cpp?
5 years, 7 months ago (2015-05-26 16:26:54 UTC) #14
reed1
https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp#newcode40 src/pdf/SkPDFDevice.cpp:40: static void fix_paint_xfermode(SkPaint* paint) { "fix" is not very ...
5 years, 7 months ago (2015-05-26 16:28:23 UTC) #16
tomhudson
On 2015/05/26 16:28:23, reed1 wrote: > https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp > File src/pdf/SkPDFDevice.cpp (right): > > https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp#newcode40 > ...
5 years, 7 months ago (2015-05-26 16:54:22 UTC) #17
hal.canary
On 2015/05/26 16:26:54, reed1 wrote: > can we do code-sharing w/ interpret_xfermode in SkBlitter.cpp? done. ...
5 years, 7 months ago (2015-05-26 18:23:41 UTC) #18
hal.canary
https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/1159763004/diff/20001/src/pdf/SkPDFDevice.cpp#newcode40 src/pdf/SkPDFDevice.cpp:40: static void fix_paint_xfermode(SkPaint* paint) { On 2015/05/26 16:28:23, reed1 ...
5 years, 7 months ago (2015-05-26 18:24:19 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159763004/80001
5 years, 7 months ago (2015-05-26 18:37:45 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-26 18:47:50 UTC) #24
reed1
lgtm https://codereview.chromium.org/1159763004/diff/80001/src/core/SkXfermodeInterpretation.h File src/core/SkXfermodeInterpretation.h (right): https://codereview.chromium.org/1159763004/diff/80001/src/core/SkXfermodeInterpretation.h#newcode14 src/core/SkXfermodeInterpretation.h:14: action. This enum lists our possible actions. */ ...
5 years, 7 months ago (2015-05-27 15:45:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159763004/80001
5 years, 7 months ago (2015-05-27 15:53:01 UTC) #27
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 15:53:39 UTC) #28
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/a681433d42323d6d48e1aa3cb2ef97fb9d958d93

Powered by Google App Engine
This is Rietveld 408576698