Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1159743005: Provide iOS implementation of BookmarkServerClusterService factory (Closed)

Created:
5 years, 6 months ago by sdefresne
Modified:
5 years, 6 months ago
Reviewers:
droger
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bookmark_service_cluster
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide iOS implementation of BookmarkServerClusterService factory Expand the KeyedServiceProvider interface to allow creation of KeyedServices required by BookmarkServerClusterService constructor and to give access to the corresponding factories (for dependencies). Implement iOS version of BookmarkServerClusterService factory and change the iOS code to use that implementation instead of the one from //chrome. BUG=429756 Committed: https://crrev.com/61088dc6bf37c7480199561d11f4cf14cf696bb6 Cr-Commit-Position: refs/heads/master@{#332375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, --1 lines) Patch
M ios/chrome/browser/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
A + ios/chrome/browser/enhanced_bookmarks/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ios/chrome/browser/enhanced_bookmarks/bookmark_server_cluster_service_factory.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/enhanced_bookmarks/bookmark_server_cluster_service_factory.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/keyed_service_provider.h View 2 chunks +49 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/keyed_service_provider.cc View 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 6 months ago (2015-06-01 18:53:54 UTC) #2
droger
lgtm
5 years, 6 months ago (2015-06-02 08:06:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159743005/1
5 years, 6 months ago (2015-06-02 12:21:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 12:48:59 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 12:49:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61088dc6bf37c7480199561d11f4cf14cf696bb6
Cr-Commit-Position: refs/heads/master@{#332375}

Powered by Google App Engine
This is Rietveld 408576698