The extensions service wasn't getting inited despite being used by themes (th...

The extensions service wasn't getting inited despite being used by themes (this manifested itself as theme reinstall failing, because CheckCurrentVersion found the directory, but ExtensionService::extensions_ was empty).

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17373

[Aaron Boodman, 2009-05-31 01:04:07]

On 2009/05/30 23:10:14, Glen Murphy wrote:
> 

lgtm

This looks fine, but it looks to me like we currently check --enable-extensions
after an extension is unpacked. It's a bit paranoid, but can we move this up
earlier so that we don't even bother trying to unpack anything if
--enable-extensions isn't present?

[Glen Murphy, 2009-05-31 01:14:53]

Don't we need to unpack it to get to the manifest (and figure out if it's a
theme or not)?

[Glen Murphy, 2009-05-31 07:39:01]

FWIW, this patch appears to cause the RendererCrashTest UI test to fail
consistently (commenting out extensions_service_->Init consistently fixes it).
Investigating.

[Glen Murphy, 2009-05-31 08:18:08]

For lack of a better place to put this. It appears that this is caused by

BrowserRenderProcessHost::SendUserScriptsUpdate
from BrowserRenderProcessHost::Observe (USER_SCRIPTS_UPDATED)
from UserScriptMaster::NewScriptsAvailable
from UserScriptMaster::ScriptReloader::NotifyMaster
from UserScriptMaster::StartScan
from UserScriptMaster::Observe (EXTENSION_LOADED)

Should UserScriptMaster exist if (userscripts || extensions) aren't enabled? I'm
not even sure if there are any user scripts present in the test.

[Glen Murphy, 2009-06-01 18:32:41]

Reuploaded with addition of an 'enabled_' state to UserScriptMaster, which seems
cleaner than adding commandline+profile awareness to it.

[Glen Murphy, 2009-06-01 22:22:58]

Rereuploaded. Themes now never fire EXTENSIONS_LOADED.

[Aaron Boodman, 2009-06-01 23:44:36]

lgtm

http://codereview.chromium.org/115974/diff/1021/21
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/115974/diff/1021/21#newcode341
Line 341: if (has_extension) {
Can you add:

TODO(aa): This can be re-enabled when BUG XXX is fixed.