Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159733006: Revert[4] of add asserts around results from requestLock (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[4] of add asserts around results from requestLock This reverts commit 19663e54c017499406036746e7689193aa6417e6. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/df91b73a34e3a306c93a5e320704736255c3d9f0

Patch Set 1 #

Patch Set 2 : check for null pixels in installPixels #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -28 lines) Patch
M include/core/SkPixelRef.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPixelRef.cpp View 5 chunks +42 lines, -26 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159733006/20001
5 years, 6 months ago (2015-05-30 12:50:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159733006/40001
5 years, 6 months ago (2015-05-30 13:19:51 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/df91b73a34e3a306c93a5e320704736255c3d9f0
5 years, 6 months ago (2015-05-30 13:32:59 UTC) #6
reed2
5 years, 6 months ago (2015-05-30 16:20:17 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1151063005/ by reed@chromium.org.

The reason for reverting is: gfx_unittests (under linux_asan)

@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Direct leak of 368
byte(s) in 1 object(s) allocated from:@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #0 0x4cc74b in
__interceptor_malloc
(/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #1
0x7f2f7060ebdf in _cairo_image_surface_create_for_pixman_image
/build/buildd/cairo-1.10.2/src/cairo-image-surface.c:158@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@Indirect leak of
256 byte(s) in 1 object(s) allocated from:@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #0 0x4cc74b in
__interceptor_malloc
(/b/build/slave/linux_asan/build/src/out/Release/gfx_unittests+0x4cc74b)@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@    #1
0x7f2f6c7be26a in _pixman_image_allocate
/build/buildd/pixman-0.30.2/build/pixman/../../pixman/pixman-image.c:184@@@
@@@STEP_LOG_LINE@RenderTextTest.HarfBuzz_HorizontalPositions@@@@


I think they are creating a cairo surface, but it has no pixels (zero size?). In
this CL, if I see no pixels, I ignore the call-back which is used to free the
surface (doh).
.

Powered by Google App Engine
This is Rietveld 408576698