chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc - Issue 1159733004: Encapsulate CSS selector declarative content condition tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

Issue 1159733004: Encapsulate CSS selector declarative content condition tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stars-declarative-content-range-for

Patch Set: iwyu Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc ('K') | « chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative_content/content_action.h » ('j') | chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

index 4c6c04ce7b7e6c28bcd1dc0cbd611324d5cb0a4c..89c642e0a15415c5628662be3d2b70783a02ec2c 100644

--- a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc

@@ -7,7 +7,6 @@

#include <string>

#include "base/test/values_test_util.h"

-#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/test_extension_environment.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/browser/navigation_details.h"

@@ -79,7 +78,7 @@ TEST_F(DeclarativeChromeContentRulesRegistryTest, ActiveRulesDoesntGrow) {

std::vector<std::string> css_selectors;

css_selectors.push_back("input");

- registry->Apply(tab.get(), css_selectors);

+ registry->UpdateMatchingCssSelectorsForTesting(tab.get(), css_selectors);

EXPECT_EQ(1u, active_rules(*registry.get()).size());

// Closing the tab should erase its entry from active_rules_.

@@ -87,7 +86,7 @@ TEST_F(DeclarativeChromeContentRulesRegistryTest, ActiveRulesDoesntGrow) {

EXPECT_EQ(0u, active_rules(*registry.get()).size());

tab = env.MakeTab();

- registry->Apply(tab.get(), css_selectors);

+ registry->UpdateMatchingCssSelectorsForTesting(tab.get(), css_selectors);

EXPECT_EQ(1u, active_rules(*registry.get()).size());

// Navigating the tab should erase its entry from active_rules_ if

// it no longer matches.