tools/perf/page_sets/tough_texture_upload_cases.py - Issue 1159733003: Added Tough Texture upload page set to smoothness benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_texture_upload_cases.py

Issue 1159733003: Added Tough Texture upload page set to smoothness benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change to animation interaction Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | tools/perf/page_sets/tough_texture_upload_cases/extra_large_texture_uploads.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/tough_texture_upload_cases.py

diff --git a/tools/perf/page_sets/tough_texture_upload_cases.py b/tools/perf/page_sets/tough_texture_upload_cases.py

index 2cef31d1547616766988248312f270ad2083a6ba..2a712ca9e50a5edeb81d9b1d5abd1c489acccbd9 100644

--- a/tools/perf/page_sets/tough_texture_upload_cases.py

+++ b/tools/perf/page_sets/tough_texture_upload_cases.py

@@ -15,8 +15,8 @@ class ToughTextureUploadCasesPage(page_module.Page):

page_set=page_set)

def RunPageInteractions(self, action_runner):

- with action_runner.CreateGestureInteraction('ScrollAction'):

- action_runner.ScrollPage()

+ with action_runner.CreateInteraction('Animation'):

+ action_runner.Wait(10)

nednguyen 2015/05/26 17:50:46 Since these are pages that we control, can we do a

David Yen 2015/05/26 17:53:44 All of these pages just loop an animation infinite

class ToughTextureUploadCasesPageSet(page_set_module.PageSet):

@@ -35,7 +35,12 @@ class ToughTextureUploadCasesPageSet(page_set_module.PageSet):

# pylint: disable=C0301

'file://tough_texture_upload_cases/background_color_animation_with_gradient.html',

# pylint: disable=C0301

- 'file://tough_texture_upload_cases/background_color_animation_with_gradient_and_transform_animation.html']

+ 'file://tough_texture_upload_cases/background_color_animation_with_gradient_and_transform_animation.html',

+ 'file://tough_texture_upload_cases/small_texture_uploads.html',

+ 'file://tough_texture_upload_cases/medium_texture_uploads.html',

+ 'file://tough_texture_upload_cases/large_texture_uploads.html',

+ 'file://tough_texture_upload_cases/extra_large_texture_uploads.html',

+ ]

for url in urls_list:

self.AddUserStory(ToughTextureUploadCasesPage(url, self))