Resubmit of imageWriterPrivate.destroyPartitions.

Resubmit of imageWriterPrivate.destroyPartitions.

Previous CL: https://codereview.chromium.org/109793006/

BUG=328246
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243191

[Drew Haven, 2013-12-26 23:27:23]

Apparently this CL got reverted due to some valgrind errors.  I'm not sure how
my change would have caused that and I'm still trying to reproduce it.  In the
mean time I'd like to request a stamp LTGM so that I can resubmit when I've
figured it out.

[asargent_no_longer_on_chrome, 2014-01-02 23:38:39]

It might be helpful to add a link in the description to the previous codereview
entry before you submit. 

Otherwise lgtm.

[Drew Haven, 2014-01-03 17:43:22]

Oh yeah, sorry about that.  I forget that not everyone has the same context
I do.  I'll do that in the future.


On Thu, Jan 2, 2014 at 3:38 PM, <asargent@chromium.org> wrote:

> It might be helpful to add a link in the description to the previous
> codereview
> entry before you submit.
>
> Otherwise lgtm.
>
>
>
> https://codereview.chromium.org/115973007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-06 18:51:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haven@chromium.org/115973007/1

[commit-bot: I haz the power, 2014-01-06 22:50:29]

Change committed as 243191

[Drew Haven, 2014-01-07 00:46:46]

A revert of this CL has been created in
https://codereview.chromium.org/125273006/ by haven@chromium.org.

The reason for reverting is: Triggered Valgrind errors again..

[Lei Zhang, 2014-01-07 00:56:37]

https://codereview.chromium.org/115973007/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/image_writer_private/test_utils.cc (right):

https://codereview.chromium.org/115973007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/image_writer_private/test_utils.cc:81:
chromeos::DBusThreadManager::InitializeForTesting(fake_dbus_thread_manager);
Likely you are missing a corresponding chrome::DBusThreadManager::Shutdown()
call in TearDown() below. Resubmit the CL and ask satorux@ to review this part.