Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: Source/core/loader/FrameLoader.h

Issue 1159723003: Don't reuse HistoryItems for multiple navigations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoader.h
diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h
index 1cabfeb76d65cfc24a2fda9f914fd112d90a5c9c..9fb261c98258874664bf594a1dbed90d3489f1c9 100644
--- a/Source/core/loader/FrameLoader.h
+++ b/Source/core/loader/FrameLoader.h
@@ -171,7 +171,6 @@ public:
HistoryItem* currentItem() const { return m_currentItem.get(); }
void saveScrollState();
- void clearScrollPositionAndViewState();
void restoreScrollPositionAndViewState();
@@ -192,8 +191,7 @@ private:
void startLoad(FrameLoadRequest&, FrameLoadType, NavigationPolicy);
-
- void setHistoryItemStateForCommit(HistoryCommitType, bool isPushOrReplaceState = false, HistoryScrollRestorationType = ScrollRestorationAuto, PassRefPtr<SerializedScriptValue> = nullptr);
+ void setHistoryItemStateForCommit(HistoryCommitType, bool isSameDocument, bool isPushOrReplaceState = false);
dcheng 2015/06/02 19:11:36 I'd prefer to see enum parameters here instead of
Nate Chapin 2015/06/02 21:18:57 Done.
void loadInSameDocument(const KURL&, PassRefPtr<SerializedScriptValue> stateObject, FrameLoadType, ClientRedirectPolicy);

Powered by Google App Engine
This is Rietveld 408576698