Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/platform/heap/GCInfo.cpp

Issue 1159703002: Oilpan: assertObjectHasGCInfo should not allow access to orphaned pages (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/GCInfo.cpp
diff --git a/Source/platform/heap/GCInfo.cpp b/Source/platform/heap/GCInfo.cpp
index 39c652cec8e03ab2b6fd846640d02eee4e6e5ea1..dede86c839844f6ee40832e463347c056a951243 100644
--- a/Source/platform/heap/GCInfo.cpp
+++ b/Source/platform/heap/GCInfo.cpp
@@ -76,7 +76,8 @@ void assertObjectHasGCInfo(const void* payload, size_t gcInfoIndex)
// On component builds we cannot compare the gcInfos as they are statically
// defined in each of the components and hence will not match.
BasePage* page = pageFromObject(payload);
- ASSERT(page->orphaned() || HeapObjectHeader::fromPayload(payload)->gcInfoIndex() == gcInfoIndex);
+ ASSERT(!page->orphaned());
+ ASSERT(HeapObjectHeader::fromPayload(payload)->gcInfoIndex() == gcInfoIndex);
#endif
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698