Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 1159703002: Oilpan: assertObjectHasGCInfo should not allow access to orphaned pages (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: assertObjectHasGCInfo should not allow access to orphaned pages This CL removes ASSERT(page->orphaned() || ...) from assertObjectHasGCInfo(), since orphaned pages must not be accessed in any way. BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196375

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/platform/heap/GCInfo.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
4 years, 11 months ago (2015-05-26 01:14:06 UTC) #2
keishi
lgtm
4 years, 11 months ago (2015-06-02 02:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159703002/20001
4 years, 11 months ago (2015-06-02 03:21:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64719)
4 years, 11 months ago (2015-06-02 07:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159703002/20001
4 years, 11 months ago (2015-06-03 03:54:23 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 07:04:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196375

Powered by Google App Engine
This is Rietveld 408576698