Issue 11597005: Do not update FileSystemUsageCache if the delta is zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11597005: Do not update FileSystemUsageCache if the delta is zero (Closed)

Created:
8 years ago by tzik

Modified:
8 years ago

Reviewers:
kinuko

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not update FileSystemUsageCache if the delta is zero BUG=166158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173439

Patch Set 2 : s/if (delta)/if(delta != 0)/ #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webkit/fileapi/sandbox_quota_observer.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm https://codereview.chromium.org/11597005/diff/1/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11597005/diff/1/webkit/fileapi/sandbox_quota_observer.cc#newcode43 webkit/fileapi/sandbox_quota_observer.cc:43: if (delta) nit: while I'm in chrome I ...

8 years ago (2012-12-17 08:14:56 UTC) #2

tzik

https://codereview.chromium.org/11597005/diff/1/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11597005/diff/1/webkit/fileapi/sandbox_quota_observer.cc#newcode43 webkit/fileapi/sandbox_quota_observer.cc:43: if (delta) On 2012/12/17 08:14:56, kinuko wrote: > nit: ...

8 years ago (2012-12-17 08:18:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11597005/4001

8 years ago (2012-12-17 08:19:15 UTC) #4

Message was sent while issue was closed.

Change committed as 173439

Expand Messages | Collapse Messages

Issue 11597005: Do not update FileSystemUsageCache if the delta is zero (Closed)

Description

Patch Set 1 #

Patch Set 2 : s/if (delta)/if(delta != 0)/ #

Messages