Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1159663004: Implement %TypedArray%.prototype.{reduce,reduceRight} (Closed)

Created:
5 years, 6 months ago by dehrenberg
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement %TypedArray%.prototype.{reduce,reduceRight} This patch re-commits a previous commit after fixing a test to not run into another known bug. This reverts commit b104a67ef0a50beab2dc85a6ac5732c696d07698. This patch implements the last two methods on TypedArrays. These were previously committed and led to a test failure. BUG=v8:3578 LOG=Y R=adamk Committed: https://crrev.com/c1e3e3018e5833f1377bb72648c938fea7f53b03 Cr-Commit-Position: refs/heads/master@{#28803}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -14 lines) Patch
M src/array.js View 4 chunks +27 lines, -14 lines 0 comments Download
M src/harmony-typedarray.js View 4 chunks +28 lines, -0 lines 0 comments Download
M src/prologue.js View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typedarray-reduce.js View 1 chunk +252 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
dehrenberg
5 years, 6 months ago (2015-06-04 05:50:16 UTC) #1
adamk
lgtm https://codereview.chromium.org/1159663004/diff/1/test/mjsunit/harmony/typedarray-reduce.js File test/mjsunit/harmony/typedarray-reduce.js (right): https://codereview.chromium.org/1159663004/diff/1/test/mjsunit/harmony/typedarray-reduce.js#newcode242 test/mjsunit/harmony/typedarray-reduce.js:242: // Shadowing length doesn't affect every, unlike Array.prototype.every ...
5 years, 6 months ago (2015-06-04 16:10:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159663004/1
5 years, 6 months ago (2015-06-04 16:10:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 16:36:44 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 16:36:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1e3e3018e5833f1377bb72648c938fea7f53b03
Cr-Commit-Position: refs/heads/master@{#28803}

Powered by Google App Engine
This is Rietveld 408576698