Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159663003: Re-land "Add a Color class to dart:sky." (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
jackson
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, abarth-chromium
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Re-land "Add a Color class to dart:sky." The previous patch broke the sky tests. I have updated the framework to use the new Color class. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/4eb7c8b1238fe8a6895fa4ebbbd7db9971681b0f

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : ink_well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -14 lines) Patch
M sky/engine/bindings/scripts/dart_types.py View 3 chunks +5 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
A sky/engine/core/painting/CanvasColor.h View 1 chunk +31 lines, -0 lines 0 comments Download
A sky/engine/core/painting/CanvasColor.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
A sky/engine/core/painting/Color.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M sky/examples/raw/ink_well.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sky/examples/raw/painting.sky View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/rendering/render_box.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M sky/tests/resources/display_list.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Matt Perry
Turns out the test failures were mine. I fixed some callers (see render_box.dart and ink_well.dart), ...
5 years, 6 months ago (2015-06-02 18:00:58 UTC) #2
jackson
lgtm
5 years, 6 months ago (2015-06-02 18:04:10 UTC) #3
Matt Perry
5 years, 6 months ago (2015-06-02 18:09:46 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4eb7c8b1238fe8a6895fa4ebbbd7db9971681b0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698