Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159633002: Clean up ui<->cc layers interface. (Closed)

Created:
5 years, 7 months ago by loyso (OOO)
Modified:
5 years, 7 months ago
Reviewers:
Ian Vollick, ajuma, piman
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ui<->cc layers interface. Previous episode: https://codereview.chromium.org/1101823002 BUG=394777 R=piman@chromium.org R=ajuma@chromium.org R=vollick@chromium.org Committed: https://crrev.com/ac00846c699607e5b7834e8aacc537a101678096 Cr-Commit-Position: refs/heads/master@{#331498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -98 lines) Patch
M ui/compositor/compositor.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/compositor/dip_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/layer.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 3 chunks +22 lines, -15 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 17 chunks +72 lines, -71 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
loyso (OOO)
5 years, 7 months ago (2015-05-25 06:38:33 UTC) #1
piman
lgtm
5 years, 7 months ago (2015-05-26 16:44:23 UTC) #2
Ian Vollick
On 2015/05/26 at 16:44:23, piman wrote: > lgtm lgtm, too.
5 years, 7 months ago (2015-05-27 00:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159633002/1
5 years, 7 months ago (2015-05-27 00:06:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 01:05:57 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 01:06:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ac00846c699607e5b7834e8aacc537a101678096
Cr-Commit-Position: refs/heads/master@{#331498}

Powered by Google App Engine
This is Rietveld 408576698