Move Element.style to HTMLElement

Move Element.style to HTMLElement 

Move out from Element interface currently included attribute style. This
attribute is moved to HTMLElement. SVGElement already includes style
attribute.

R=philipj@opera.com
BUG=497376
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196771

[Habib Virji, 2015-06-08 15:54:35]

Please have a look.

[Habib Virji, 2015-06-08 15:55:17]

On 2015/06/08 15:54:35, Habib Virji wrote:
> Please have a look.

The Linux test layout failure does not seem to be related to the changes.

[Rick Byers, 2015-06-08 15:58:07]

rbyers@chromium.org changed reviewers:
- pdr@chromium.org, rbyers@chromium.org

[Rick Byers, 2015-06-08 15:59:49]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2015-06-08 15:59:50]

Philip is perhaps the best reviewer (right Philip?  Feel free to switch if
there's someone better).

Moving myself and pdr to cc.  Minimizing unnecessary overlapping reviewers will
help to reduce review time.

[philipj_slow, 2015-06-08 18:08:34]

Starting mac_blink_rel to see if the same test fails. Now that we have the CQ
dry run, I would encourage you to do `git cl upload --cq-dry-run` and ask for
review once that's come back looking good.

https://codereview.chromium.org/1159623015/diff/20001/Source/core/html/HTMLEl...
File Source/core/html/HTMLElement.idl (right):

https://codereview.chromium.org/1159623015/diff/20001/Source/core/html/HTMLEl...
Source/core/html/HTMLElement.idl:54: // Styling
Please keep the spec name, link and [PutForwards] FIXME from Element.idl, making
this CL only about moving style to HTMLElement and SVGElement. If you'd like to
do the [PutForwards] change as well, that's suitable for a follow-up CL, but it
would need accompanying tests.

https://codereview.chromium.org/1159623015/diff/20001/Source/core/svg/SVGElem...
File Source/core/svg/SVGElement.idl (right):

https://codereview.chromium.org/1159623015/diff/20001/Source/core/svg/SVGElem...
Source/core/svg/SVGElement.idl:27: [SameObject, PutForwards=cssText] readonly
attribute CSSStyleDeclaration style;
Actually the spec IDL matches the old state of the file, no extended attributes.
I suppose that means it would be wise to hold off any [PutForwards] change in
HTMLElement until it's known whether SVGElement should have the same.

[philipj_slow, 2015-06-08 18:11:46]

I noticed there are two specs defining SVGElement.style and filed this spec bug:
https://github.com/w3c/svgwg/issues/20

[philipj_slow, 2015-06-08 21:29:23]

Looks like the
fast/forms/input-width-height-attributes-without-renderer-loaded-image.html
failure is a real regression, and since it sets e.style = "display:none" it must
be because of the [PutForwards] change. If you leave that out there should be no
problem.

[Habib Virji, 2015-06-09 08:57:32]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 08:57:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159623015/40001

[commit-bot: I haz the power, 2015-06-09 09:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 09:01:01]

Dry run: Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/58174)

[Habib Virji, 2015-06-09 09:38:53]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 09:38:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159623015/60001

[commit-bot: I haz the power, 2015-06-09 11:08:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 11:08:14]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Habib Virji, 2015-06-09 11:23:07]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 11:23:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159623015/80001

[Habib Virji, 2015-06-09 12:22:17]

Thanks Philip.

Updated code as suggested and cq-dry-run has also been done. 

Will hold on  putforward changes till your query on SVG spec is answered.

https://codereview.chromium.org/1159623015/diff/20001/Source/core/html/HTMLEl...
File Source/core/html/HTMLElement.idl (right):

https://codereview.chromium.org/1159623015/diff/20001/Source/core/html/HTMLEl...
Source/core/html/HTMLElement.idl:54: // Styling
Done.

https://codereview.chromium.org/1159623015/diff/20001/Source/core/svg/SVGElem...
File Source/core/svg/SVGElement.idl (right):

https://codereview.chromium.org/1159623015/diff/20001/Source/core/svg/SVGElem...
Source/core/svg/SVGElement.idl:27: [SameObject, PutForwards=cssText] readonly
attribute CSSStyleDeclaration style;
It is changed back to old state.

[commit-bot: I haz the power, 2015-06-09 12:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 12:41:32]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2015-06-09 13:02:09]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-06-09 13:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159623015/80001

[commit-bot: I haz the power, 2015-06-09 13:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 13:03:04]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[philipj_slow, 2015-06-09 15:18:57]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-09 15:18:58]

lgtm

[commit-bot: I haz the power, 2015-06-09 15:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159623015/80001

[commit-bot: I haz the power, 2015-06-09 15:23:26]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196771