Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1159623015: Move Element.style to HTMLElement (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, vivekg, dglazkov+blink, krit, f(malita), Inactive, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis, Rick Byers, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Element.style to HTMLElement Move out from Element interface currently included attribute style. This attribute is moved to HTMLElement. SVGElement already includes style attribute. R=philipj@opera.com BUG=497376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196771

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Updated to only include changes related to moving out from Element.idl, no PutForwards changes are … #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase added a tabStop, removed it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
Habib Virji
Please have a look.
5 years, 6 months ago (2015-06-08 15:54:35 UTC) #1
Habib Virji
On 2015/06/08 15:54:35, Habib Virji wrote: > Please have a look. The Linux test layout ...
5 years, 6 months ago (2015-06-08 15:55:17 UTC) #2
Rick Byers
Philip is perhaps the best reviewer (right Philip? Feel free to switch if there's someone ...
5 years, 6 months ago (2015-06-08 15:59:50 UTC) #5
philipj_slow
Starting mac_blink_rel to see if the same test fails. Now that we have the CQ ...
5 years, 6 months ago (2015-06-08 18:08:34 UTC) #6
philipj_slow
I noticed there are two specs defining SVGElement.style and filed this spec bug: https://github.com/w3c/svgwg/issues/20
5 years, 6 months ago (2015-06-08 18:11:46 UTC) #7
philipj_slow
Looks like the fast/forms/input-width-height-attributes-without-renderer-loaded-image.html failure is a real regression, and since it sets e.style = ...
5 years, 6 months ago (2015-06-08 21:29:23 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623015/40001
5 years, 6 months ago (2015-06-09 08:57:53 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46905) mac_blink_rel on ...
5 years, 6 months ago (2015-06-09 09:01:01 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623015/60001
5 years, 6 months ago (2015-06-09 09:38:57 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65689)
5 years, 6 months ago (2015-06-09 11:08:14 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623015/80001
5 years, 6 months ago (2015-06-09 11:23:48 UTC) #18
Habib Virji
Thanks Philip. Updated code as suggested and cq-dry-run has also been done. Will hold on ...
5 years, 6 months ago (2015-06-09 12:22:17 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 12:41:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623015/80001
5 years, 6 months ago (2015-06-09 13:02:58 UTC) #23
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-09 13:03:04 UTC) #25
philipj_slow
lgtm
5 years, 6 months ago (2015-06-09 15:18:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623015/80001
5 years, 6 months ago (2015-06-09 15:19:40 UTC) #28
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 15:23:26 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196771

Powered by Google App Engine
This is Rietveld 408576698