Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1159623014: Revert of Encapsulate CSS selector declarative content condition tracking (Closed)

Created:
5 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@stars-declarative-content-range-for
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Encapsulate CSS selector declarative content condition tracking (patchset #6 id:140001 of https://codereview.chromium.org/1159733004/) Reason for revert: Stability sheriff here; I'm speculatively rolling this out because I suspect it caused Issue 497586. Original issue's description: > Encapsulate CSS selector declarative content condition tracking > > This is the first step in a refactoring of the declarativeContent API > implementation. The goal is to facilitate profile state matching by > providing abstractions for conditions and condition state tracking > and evaluation. > > This CL consists of steps 1 and 2 described in the associated bug: > by-hand instantiation of DeclarativeRule as DeclarativeContentRule to > decouple changes from the web request declarative API implementation, > and encapsulation of CSS selector condition tracking logic. No > functional change is intended. > > BUG=492946 > > Committed: https://crrev.com/fe76220cf0a1cdcfe74ca7daeae9f1da2b91cc6b > Cr-Commit-Position: refs/heads/master@{#333144} TBR=kalman@chromium.org,jyasskin@chromium.org,wittman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492946 Committed: https://crrev.com/4fcf9f62d9099af2e55186d9c423e2ded4fdca0d Cr-Commit-Position: refs/heads/master@{#333238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -739 lines) Patch
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h View 7 chunks +31 lines, -38 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc View 11 chunks +71 lines, -71 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc View 3 chunks +38 lines, -30 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_condition.h View 2 chunks +2 lines, -6 lines 0 comments Download
D chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.h View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker_unittest.cc View 1 chunk +0 lines, -199 lines 0 comments Download
M chrome/browser/extensions/tab_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_content/content_rules_registry.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominicc (has gone to gerrit)
Created Revert of Encapsulate CSS selector declarative content condition tracking
5 years, 6 months ago (2015-06-08 04:14:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623014/1
5 years, 6 months ago (2015-06-08 04:15:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 04:15:37 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 04:16:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fcf9f62d9099af2e55186d9c423e2ded4fdca0d
Cr-Commit-Position: refs/heads/master@{#333238}

Powered by Google App Engine
This is Rietveld 408576698