Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1159623007: Don't auto-wrap <svg:text> (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't auto-wrap <svg:text> Even if an explicit 'white-space' property overrides the presentation attribute style (from 'xml:space'), auto-wrap should still be disabled (until "wrappable text" a'la SVG2 has been implemented.) BUG=492596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
A LayoutTests/svg/text/white-space-no-autowrap.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/white-space-no-autowrap-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 6 months ago (2015-06-01 16:04:55 UTC) #2
pdr.
+cc eae just FYI. LGTM
5 years, 6 months ago (2015-06-01 22:14:34 UTC) #4
eae
LGTM
5 years, 6 months ago (2015-06-01 22:15:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623007/1
5 years, 6 months ago (2015-06-02 08:17:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 08:20:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196298

Powered by Google App Engine
This is Rietveld 408576698