Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1159613003: Devtools Animations: Update timing information of related animations (Closed)

Created:
5 years, 7 months ago by samli
Modified:
5 years, 5 months ago
Reviewers:
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Animations: Update timing information of related animations Due to unwanted additional complexity of dealing with property lists, the animation timeline updates the inline style for CSS transitions & animations. As a result, changes to timing can affect mulitple animations. This change reflects these timing changes to all affected animations. BUG=447083

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -78 lines) Patch
M Source/devtools/front_end/elements/AnimationTimeline.js View 1 14 chunks +163 lines, -77 lines 0 comments Download
M Source/devtools/front_end/elements/animationTimeline.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
samli
ptal
5 years, 7 months ago (2015-05-25 07:11:16 UTC) #2
samli
test case: http://jsfiddle.net/77hcszL6/
5 years, 7 months ago (2015-05-26 06:38:04 UTC) #3
samli
On 2015/05/26 at 06:38:04, samli wrote: > test case: http://jsfiddle.net/77hcszL6/ This patch builds on https://codereview.chromium.org/1155773002 ...
5 years, 7 months ago (2015-05-26 06:41:49 UTC) #4
pfeldman
Played with this use case in ToT, looked at the video. I don't think either ...
5 years, 7 months ago (2015-05-26 13:38:05 UTC) #5
pfeldman
5 years, 7 months ago (2015-05-26 13:38:34 UTC) #6
(we should file a bug and discuss it there).

Powered by Google App Engine
This is Rietveld 408576698