Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 11596005: Revert 173406 - Crashes on Win & Mac (Closed)

Created:
8 years ago by Ryan Sleevi
Modified:
8 years ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert 173406 - Crashes on Win & Mac [cc] Fold more update calls into updateDrawProperties Now that we have a clean update system, we can remove the manual calling of updateRootScrollLayerImplTransform and other similar kinds of "I'm going to do something manually in a half dozen places because I can." This removes some surface area on LTHI which helps with the LTHI->LTI push. BUG=155209 R=enne,skyostil Review URL: https://chromiumcodereview.appspot.com/11529006 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -73 lines) Patch
M cc/layer_impl_unittest.cc View 5 chunks +3 lines, -6 lines 0 comments Download
M cc/layer_tree_host_impl.h View 4 chunks +12 lines, -8 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 5 chunks +36 lines, -9 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 16 chunks +23 lines, -39 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.h View 1 chunk +1 line, -5 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
8 years ago (2012-12-17 01:57:11 UTC) #1
Ryan Sleevi
8 years ago (2012-12-17 01:58:56 UTC) #2
Message was sent while issue was closed.
Win Failure:
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28...

Mac Failure:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.7%20Tests%...

Win failure not reproduced here because it's so dang large (due to corrupting
memory). Mac failure makes it much clearer of this fact:

[ RUN      ] LayerImplTest.VerifyNeedsUpdateDrawProperties
cc_unittests(2212,0xac0f12c0) malloc: *** mmap(size=1048576) failed (error
code=12)
*** error: can't allocate region securely
*** set a breakpoint in malloc_error_break to debug
cc_unittests(2212,0xac0f12c0) malloc: *** mmap(size=1048576) failed (error
code=12)
*** error: can't allocate region securely
*** set a breakpoint in malloc_error_break to debug
terminate called throwing an exceptioncc_unittests(2212,0xac0f12c0) malloc: ***
mmap(size=1048576) failed (error code=12)
*** error: can't allocate region securely
*** set a breakpoint in malloc_error_break to debug
Received signal 6
 [0x87b820]
 [0x90fcd59b]
 [0xffffffff]
 [0x90f68bdd]
 [0x9781b921]
 [0x978191bc]
 [0x978191fe]
 [0x97819268]
 [0x9781a2a0]
 [0x9c46d401]
 [0x9c45a040]
 [0x9c45bd69]
 [0x9c45be76]
 [0x89a076]
 [0x85d45d]
 [0x81bd5c]
 [0x1627db]
 [0x7d2eb2]
 [0x7cb247]
 [0x7cb604]
 [0x7cba1b]
 [0x7d0eab]
 [0x7d3422]
 [0x7d0acf]
 [0x711300]
 [0x8e37e]
 [0x8e335]
 [0x4]
ax: 0, bx: 9781c330, cx: c0072a2c, dx: 9981f9c6
di: ac0f12c0, si: 6, bp: c0072a48, sp: c0072a2c, ss: 23, flags: 246
ip: 9981f9c6, cs: b, ds: 23, es: 23, fs: 0, gs: f
Note: This is test shard 15 of 20.

Powered by Google App Engine
This is Rietveld 408576698