Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1159593006: Revert of Remove the allowfullscreen exemption for the video-specific fullscreen API (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, rwlbuis, sof, nessy, vcarbune.chromium
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove the allowfullscreen exemption for the video-specific fullscreen API (patchset #4 id:60001 of https://codereview.chromium.org/1058783006/) Feedback from Vimeo on blink-dev asking for more time: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/MPyuWoDaz8AJ New plan for removing the allowfullscreen exemption: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/LWeJeKYvf1MJ Original issue's description: > Remove the allowfullscreen exemption for the video-specific fullscreen API > > Intent to Remove: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/Boab2WxzhBYJ > > Prompted by a question from Ali Alabbas (Microsoft) on blink-dev: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/f-V2GWatXkA/nvdHJ3xihMkJ > > TEST=LayoutTests/media/video-controls-fullscreen-iframe.html > > This test ensures that the allowfullscreen attribute is still not > required for <video controls>, even though it is for the API call. > > BUG=346236 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194106 R=falken@chromium.org BUG=496637 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196661

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -56 lines) Patch
M LayoutTests/fullscreen/full-screen-iframe-legacy.html View 1 2 chunks +5 lines, -2 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt View 1 1 chunk +5 lines, -2 lines 0 comments Download
D LayoutTests/media/video-controls-fullscreen-iframe.html View 1 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 1 chunk +3 lines, -8 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 chunks +15 lines, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
philipj_slow
Created Revert of Remove the allowfullscreen exemption for the video-specific fullscreen API
5 years, 6 months ago (2015-06-03 22:51:08 UTC) #1
falken
Hey Philip, can you help me understand Vimeo's issue? I'm hoping we still have a ...
5 years, 6 months ago (2015-06-04 00:29:14 UTC) #2
philipj_slow
On 2015/06/04 00:29:14, falken wrote: > Hey Philip, can you help me understand Vimeo's issue? ...
5 years, 6 months ago (2015-06-04 08:39:17 UTC) #3
philipj_slow
OK, PTAL, the description links to the new plan on blink-dev. If you think that ...
5 years, 6 months ago (2015-06-04 11:44:52 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159593006/200001
5 years, 6 months ago (2015-06-04 12:10:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-04 13:55:01 UTC) #8
philipj_slow
Jochen, can you PTAL? No reaction on blink-dev, but getting this revert into M44 soon ...
5 years, 6 months ago (2015-06-05 13:44:21 UTC) #10
falken
lgtm. Based on Vimeo feedback, sounds right to at least postpone this.
5 years, 6 months ago (2015-06-08 03:06:41 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-08 04:55:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159593006/200001
5 years, 6 months ago (2015-06-08 08:16:53 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 09:38:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:200001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196661

Powered by Google App Engine
This is Rietveld 408576698