Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1159593004: Revert of Converted some extension browser tests into using event pages (Closed)

Created:
5 years, 6 months ago by zhaoqin
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Converted some extension browser tests into using event pages (patchset #1 id:60001 of https://codereview.chromium.org/1108133002/) Reason for revert: browser_tests ExtensionApiTest.AutotestPrivate failed on MSan bot BUG=494815 Original issue's description: > Converted some extension browser tests into using event pages, to fix some timeout issues when background pages have their DOM timers throttled. > > R=kalman > BUG= > > Committed: https://crrev.com/1dc63af0201f5429133b814be52aab24f8d71f16 > Cr-Commit-Position: refs/heads/master@{#332059} TBR=kalman@chromium.org,oysteine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/cda8c938f06f9955ac895099d05a9db3b61f3ab5 Cr-Commit-Position: refs/heads/master@{#332159}

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
zhaoqin
Created Revert of Converted some extension browser tests into using event pages
5 years, 6 months ago (2015-06-01 03:36:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159593004/1
5 years, 6 months ago (2015-06-01 03:36:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 03:37:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cda8c938f06f9955ac895099d05a9db3b61f3ab5 Cr-Commit-Position: refs/heads/master@{#332159}
5 years, 6 months ago (2015-06-01 03:37:53 UTC) #4
oystein (OOO til 10th of July)
5 years, 6 months ago (2015-06-03 01:06:51 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1155333003/ by oysteine@chromium.org.

The reason for reverting is: Reverting the revert, the test failure was actually
fixed by this revert: https://codereview.chromium.org/1159353003.

Powered by Google App Engine
This is Rietveld 408576698