 Chromium Code Reviews
 Chromium Code Reviews Issue 1159583002:
  Eagerly sweep MediaKeySession objects.  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 1159583002:
  Eagerly sweep MediaKeySession objects.  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW | 
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef MediaKeysController_h | 5 #ifndef MediaKeysController_h | 
| 6 #define MediaKeysController_h | 6 #define MediaKeysController_h | 
| 7 | 7 | 
| 8 #include "core/page/Page.h" | 8 #include "core/page/Page.h" | 
| 9 #include "modules/ModulesExport.h" | 9 #include "modules/ModulesExport.h" | 
| 10 #include "wtf/PassOwnPtr.h" | |
| 11 | 10 | 
| 12 namespace blink { | 11 namespace blink { | 
| 13 | 12 | 
| 14 class ExecutionContext; | 13 class ExecutionContext; | 
| 15 class MediaKeysClient; | 14 class MediaKeysClient; | 
| 16 class WebContentDecryptionModule; | |
| 17 class WebEncryptedMediaClient; | 15 class WebEncryptedMediaClient; | 
| 18 | 16 | 
| 19 class MODULES_EXPORT MediaKeysController final : public NoBaseWillBeGarbageColle cted<MediaKeysController>, public WillBeHeapSupplement<Page> { | 17 class MODULES_EXPORT MediaKeysController final : public NoBaseWillBeGarbageColle cted<MediaKeysController>, public WillBeHeapSupplement<Page> { | 
| 20 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaKeysController); | 18 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaKeysController); | 
| 21 public: | 19 public: | 
| 22 WebEncryptedMediaClient* encryptedMediaClient(ExecutionContext*); | 20 WebEncryptedMediaClient* encryptedMediaClient(ExecutionContext*); | 
| 23 | 21 | 
| 24 static void provideMediaKeysTo(Page&, MediaKeysClient*); | 22 static void provideMediaKeysTo(Page&, MediaKeysClient*); | 
| 25 static MediaKeysController* from(Page* page) { return static_cast<MediaKeysC ontroller*>(WillBeHeapSupplement<Page>::from(page, supplementName())); } | 23 static MediaKeysController* from(Page* page) { return static_cast<MediaKeysC ontroller*>(WillBeHeapSupplement<Page>::from(page, supplementName())); } | 
| 26 | 24 | 
| 27 DEFINE_INLINE_VIRTUAL_TRACE() { WillBeHeapSupplement<Page>::trace(visitor); } | 25 DEFINE_INLINE_VIRTUAL_TRACE() { WillBeHeapSupplement<Page>::trace(visitor); } | 
| 28 | 26 | 
| 29 private: | 27 private: | 
| 30 explicit MediaKeysController(MediaKeysClient*); | 28 explicit MediaKeysController(MediaKeysClient*); | 
| 31 static const char* supplementName(); | 29 static const char* supplementName(); | 
| 30 | |
| 31 // Raw reference to the client implementation, which is currently owned | |
| 32 // by the WebView. Its lifetime extends past any m_client accesses. | |
| 33 // It is not on the Oilpan heap. | |
| 
haraken
2015/05/23 23:58:37
Just help me understand:
- Is this related to the
 
sof
2015/05/24 05:28:16
That matches mine, essentially. The last part is t
 | |
| 32 MediaKeysClient* m_client; | 34 MediaKeysClient* m_client; | 
| 33 }; | 35 }; | 
| 34 | 36 | 
| 35 } // namespace blink | 37 } // namespace blink | 
| 36 | 38 | 
| 37 #endif // MediaKeysController_h | 39 #endif // MediaKeysController_h | 
| 38 | 40 | 
| OLD | NEW |