Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: media/renderers/video_renderer_impl.cc

Issue 1159573005: Revert of Always post buffering state updates since they may change sink state. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@underflow
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/video_renderer_impl.cc
diff --git a/media/renderers/video_renderer_impl.cc b/media/renderers/video_renderer_impl.cc
index 3477db688009006a2526c99ce5817df0d46afb81..507599d890ba1613e62b04d0f23742dd4ff5d761 100644
--- a/media/renderers/video_renderer_impl.cc
+++ b/media/renderers/video_renderer_impl.cc
@@ -171,12 +171,8 @@
// failed.
init_cb_ = BindToCurrentLoop(init_cb);
- // Always post |buffering_state_cb_| because it may otherwise invoke reentrant
- // calls to OnTimeStateChanged() under lock, which can deadlock the compositor
- // and media threads.
- buffering_state_cb_ = BindToCurrentLoop(buffering_state_cb);
-
statistics_cb_ = statistics_cb;
+ buffering_state_cb_ = buffering_state_cb;
paint_cb_ = base::Bind(&VideoRendererSink::PaintFrameUsingOldRenderingPath,
base::Unretained(sink_));
ended_cb_ = ended_cb;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698