Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1159573005: Revert of Always post buffering state updates since they may change sink state. (Closed)

Created:
5 years, 6 months ago by Yuta Kitamura
Modified:
5 years, 6 months ago
Reviewers:
xhwang, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@underflow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always post buffering state updates since they may change sink state. (patchset #1 id:1 of https://codereview.chromium.org/1161463006/) Reason for revert: Speculative revert for Blink layout tests crashes on Nexus 4: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29 (SEGV on CrGpuMain thread is observed) Sorry if my guess is not correct; there wasn't a clear signal to identify the culprit. Original issue's description: > Always post buffering state updates since they may change sink state. > > The lock must never be held when OnTimeStateChanged() is calling into > the VideoRendererSink or we can deadlock the compositor thread. > > With video-only playback occurs a buffering state change for underflow > would immediately invoke OnTimeStateChanged(false) which would try to > stop the VideoRendererSink under lock. > > BUG=496466 > TEST=video only playback doesn't deadlock. > > Committed: https://crrev.com/9d8a53f3bf01aed28abbd1f9a713a25362c0d158 > Cr-Commit-Position: refs/heads/master@{#332772} TBR=xhwang@chromium.org,dalecurtis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496466 Committed: https://crrev.com/9fc2a61ce37405635c5528db9d5773c4f30b592d Cr-Commit-Position: refs/heads/master@{#332808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuta Kitamura
Created Revert of Always post buffering state updates since they may change sink state.
5 years, 6 months ago (2015-06-04 09:41:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159573005/1
5 years, 6 months ago (2015-06-04 09:42:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 09:42:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9fc2a61ce37405635c5528db9d5773c4f30b592d Cr-Commit-Position: refs/heads/master@{#332808}
5 years, 6 months ago (2015-06-04 09:43:29 UTC) #4
Yuta Kitamura
5 years, 6 months ago (2015-06-04 10:43:12 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1157573009/ by yutak@chromium.org.

The reason for reverting is: The original patch was innocent..

Powered by Google App Engine
This is Rietveld 408576698