Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 1159563012: Add a deprecation message for multiple shadow roots. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase more expectations. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/shadow/ElementShadow.cpp
diff --git a/Source/core/dom/shadow/ElementShadow.cpp b/Source/core/dom/shadow/ElementShadow.cpp
index 9276974aa453970fc9e0959331060577a6012e98..a11b94627e18f0af0578138171da152443bcc9fb 100644
--- a/Source/core/dom/shadow/ElementShadow.cpp
+++ b/Source/core/dom/shadow/ElementShadow.cpp
@@ -149,10 +149,14 @@ ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost, ShadowRoot::Shadow
ScriptForbiddenScope forbidScript;
if (type == ShadowRoot::OpenShadowRoot) {
- if (!youngestShadowRoot() || youngestShadowRoot()->type() == ShadowRoot::UserAgentShadowRoot)
+ if (!youngestShadowRoot()) {
shadowHost.willAddFirstOpenShadowRoot();
- else
- UseCounter::count(shadowHost.document(), UseCounter::ElementCreateShadowRootMultiple);
+ } else if (youngestShadowRoot()->type() == ShadowRoot::UserAgentShadowRoot) {
+ shadowHost.willAddFirstOpenShadowRoot();
+ UseCounter::countDeprecation(shadowHost.document(), UseCounter::ElementCreateShadowRootMultipleWithUserAgentShadowRoot);
+ } else {
+ UseCounter::countDeprecation(shadowHost.document(), UseCounter::ElementCreateShadowRootMultiple);
+ }
}
for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadowRoot())
« no previous file with comments | « LayoutTests/inspector/elements/shadow-host-display-modes-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698