Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3097)

Unified Diff: base/tuple_unittest.cc

Issue 1159553007: Move Tuple to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/tuple.h ('k') | chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/tuple_unittest.cc
diff --git a/base/tuple_unittest.cc b/base/tuple_unittest.cc
index 5b43affc600f5f7d8741f1023c8b8e1b19486b1c..55a91392353076d49f7f896dd477c8e03e2b4ad9 100644
--- a/base/tuple_unittest.cc
+++ b/base/tuple_unittest.cc
@@ -7,6 +7,8 @@
#include "base/compiler_specific.h"
#include "testing/gtest/include/gtest/gtest.h"
+namespace base {
+
namespace {
void DoAdd(int a, int b, int c, int* res) {
@@ -30,14 +32,15 @@ struct Addz {
} // namespace
TEST(TupleTest, Basic) {
- Tuple<> t0 = MakeTuple();
+ base::Tuple<> t0 = base::MakeTuple();
ALLOW_UNUSED_LOCAL(t0);
- Tuple<int> t1(1);
- Tuple<int, const char*> t2 = MakeTuple(1, static_cast<const char*>("wee"));
- Tuple<int, int, int> t3(1, 2, 3);
- Tuple<int, int, int, int*> t4(1, 2, 3, &get<0>(t1));
- Tuple<int, int, int, int, int*> t5(1, 2, 3, 4, &get<0>(t4));
- Tuple<int, int, int, int, int, int*> t6(1, 2, 3, 4, 5, &get<0>(t4));
+ base::Tuple<int> t1(1);
+ base::Tuple<int, const char*> t2 =
+ base::MakeTuple(1, static_cast<const char*>("wee"));
+ base::Tuple<int, int, int> t3(1, 2, 3);
+ base::Tuple<int, int, int, int*> t4(1, 2, 3, &get<0>(t1));
+ base::Tuple<int, int, int, int, int*> t5(1, 2, 3, 4, &get<0>(t4));
+ base::Tuple<int, int, int, int, int, int*> t6(1, 2, 3, 4, 5, &get<0>(t4));
EXPECT_EQ(1, get<0>(t1));
EXPECT_EQ(1, get<0>(t2));
@@ -62,7 +65,7 @@ TEST(TupleTest, Basic) {
EXPECT_EQ(6, get<0>(t1));
int res = 0;
- DispatchToFunction(&DoAdd, MakeTuple(9, 8, 7, &res));
+ DispatchToFunction(&DoAdd, base::MakeTuple(9, 8, 7, &res));
EXPECT_EQ(24, res);
Addy addy;
@@ -108,7 +111,7 @@ TEST(TupleTest, Copying) {
bool res = false;
// Creating the tuple should copy the class to store internally in the tuple.
- Tuple<CopyLogger, CopyLogger*, bool*> tuple(logger, &logger, &res);
+ base::Tuple<CopyLogger, CopyLogger*, bool*> tuple(logger, &logger, &res);
get<1>(tuple) = &get<0>(tuple);
EXPECT_EQ(2, CopyLogger::TimesConstructed);
EXPECT_EQ(1, CopyLogger::TimesCopied);
@@ -127,3 +130,5 @@ TEST(TupleTest, Copying) {
EXPECT_EQ(3, CopyLogger::TimesConstructed);
EXPECT_EQ(2, CopyLogger::TimesCopied);
}
+
+} // namespace base
« no previous file with comments | « base/tuple.h ('k') | chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698