Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1159553007: Move Tuple to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, skanuj+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, serviceworker-reviews, sievers+watch_chromium.org, rickyz+watch_chromium.org, michaeln, dmazzoni+watch_chromium.org, kinuko+watch, jdduke+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nektar+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, nona+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, jam, kinuko+serviceworker, jbauman+watch_chromium.org, posciak+watch_chromium.org, je_julie, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jsbell+serviceworker_chromium.org, dougw+watch_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, tapted, rouslan+spellwatch_chromium.org, nhiroki, penghuang+watch_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, yuzo+watch_chromium.org, estade+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, davidben+watch_chromium.org, kalyank, plundblad+watch_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, donnd+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, yurys, ozone-reviews_chromium.org, David Black, jln+watch_chromium.org, samarth+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kmadhusu+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Tuple to base namespace. Namespace change only, no functionality change. The only non-search-and-replace change is in generate_gmock_mutant.py which changes some line wrapping logic for the generated gmock_mutant header. NOPRESUBMIT=true (No presubmit due to long lines in the generated gmock_mutant.h header). R=sky Committed: https://crrev.com/d5ca2bc110d2bcf78dbfafc8b4f8d69663594e77 Cr-Commit-Position: refs/heads/master@{#332058}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2923 lines, -2685 lines) Patch
M base/observer_list_threadsafe.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/tuple.h View 3 chunks +7 lines, -3 lines 0 comments Download
M base/tuple_unittest.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/translate/translate_helper_browsertest.cc View 13 chunks +16 lines, -16 lines 0 comments Download
M chrome/utility/shell_handler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/guest_view/renderer/guest_view_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/login/base_screen_handler_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 10 chunks +20 lines, -13 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 12 chunks +36 lines, -30 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 2 chunks +18 lines, -17 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/external_popup_menu_browsertest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/render_media_log_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_proxy.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 16 chunks +30 lines, -30 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/alarms/alarms_api_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/extension_utility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/utility/unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_macros.h View 1 11 chunks +50 lines, -41 lines 0 comments Download
M ipc/ipc_message_utils.h View 6 chunks +62 lines, -62 lines 0 comments Download
M ipc/ipc_message_utils_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/host/dispatch_host_message.h View 1 chunk +15 lines, -13 lines 0 comments Download
M ppapi/proxy/dispatch_reply_message.h View 1 chunk +14 lines, -12 lines 0 comments Download
M ppapi/proxy/nacl_message_scanner.cc View 3 chunks +18 lines, -17 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_message_utils.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/resource_message_test_sink.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/websocket_resource_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M printing/pdf_render_settings.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/bpf_dsl/codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/codegen.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/generate_gmock_mutant.py View 1 2 6 chunks +14 lines, -10 lines 0 comments Download
M testing/gmock_mutant.h View 1 2 106 chunks +2217 lines, -2035 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 2 chunks +34 lines, -33 lines 0 comments Download
M ui/base/win/open_file_name_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/open_file_name_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/base/win/open_file_name_win_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159553007/20001
5 years, 6 months ago (2015-05-29 19:41:59 UTC) #2
brettw
5 years, 6 months ago (2015-05-29 19:42:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66913)
5 years, 6 months ago (2015-05-29 19:53:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159553007/40001
5 years, 6 months ago (2015-05-29 20:43:58 UTC) #8
sky
LGTM
5 years, 6 months ago (2015-05-29 20:46:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159553007/40001
5 years, 6 months ago (2015-05-29 20:54:58 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-29 22:16:15 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 22:17:06 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5ca2bc110d2bcf78dbfafc8b4f8d69663594e77
Cr-Commit-Position: refs/heads/master@{#332058}

Powered by Google App Engine
This is Rietveld 408576698