Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1159513003: Even without --trace-gc dump the last few GC messages on OOM (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Even without --trace-gc dump the last few GC messages on OOM If we crash V8 due to out-of-memory then we print the last 3 GCs on stdout as we crash. Also records the last 3 GCs on the stack so that it will be part of the minidump. R=hpayer@chromium.org BUG= Committed: https://crrev.com/af7e07358a41a5f3a0b81bd49bb60394a4d332ab Cr-Commit-Position: refs/heads/master@{#28704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -23 lines) Patch
M src/api.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/heap/gc-tracer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 6 chunks +39 lines, -21 lines 0 comments Download
M src/heap/heap.h View 4 chunks +14 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-05-29 10:47:12 UTC) #1
Hannes Payer (out of office)
Good idea! lgtm
5 years, 6 months ago (2015-05-29 15:47:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159513003/1
5 years, 6 months ago (2015-05-29 15:54:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 16:24:46 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 16:25:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af7e07358a41a5f3a0b81bd49bb60394a4d332ab
Cr-Commit-Position: refs/heads/master@{#28704}

Powered by Google App Engine
This is Rietveld 408576698