chrome/renderer/autofill/password_autofill_agent_browsertest.cc - Issue 1159513002: Allow autofill in iframe inside page of same origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Issue 1159513002: Allow autofill in iframe inside page of same origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update PasswordAutofillAgentTest.IframeNoFillTest Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/crossite_iframe_content.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

index 7ff193846a120f9aac107912a4ffc5da4ecbda4f..d67f09773e46744dc6032e2af9378610238d7f28 100644

--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

@@ -866,7 +866,7 @@ TEST_F(PasswordAutofillAgentTest, IframeNoFillTest) {

ASSERT_FALSE(username_element.isNull());

CheckTextFieldsStateForElements(

- username_input, "", false, password_input, "", false, false);

+ username_input, kAliceUsername, true, password_input, "", true, false);

// Simulate the user typing in the username in the iframe which should cause

// an autofill.