Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1159493010: ozone: Remove singleton pattern for SurfaceFactoryOzone. (Closed)

Created:
5 years, 6 months ago by dshwang
Modified:
5 years, 6 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove singleton pattern for SurfaceFactoryOzone. OzonePlatform is sigleton already, so it's not necessary for SurfaceFactoryOzone to be singleton. Committed: https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6 Cr-Commit-Position: refs/heads/master@{#332889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -57 lines) Patch
M content/browser/compositor/software_output_device_ozone.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 8 chunks +27 lines, -13 lines 0 comments Download
M ui/ozone/demo/software_renderer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M ui/ozone/gpu/ozone_gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 3 chunks +5 lines, -12 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
dshwang
spang, could you review?
5 years, 6 months ago (2015-06-04 13:21:10 UTC) #2
spang
lgtm
5 years, 6 months ago (2015-06-04 17:58:58 UTC) #3
dshwang
On 2015/06/04 17:58:58, spang wrote: > lgtm Thank you for reviewing. sievers, could you review ...
5 years, 6 months ago (2015-06-04 18:37:52 UTC) #4
no sievers
On 2015/06/04 18:37:52, dshwang wrote: > On 2015/06/04 17:58:58, spang wrote: > > lgtm > ...
5 years, 6 months ago (2015-06-04 18:45:17 UTC) #5
dshwang
On 2015/06/04 18:45:17, sievers wrote: > On 2015/06/04 18:37:52, dshwang wrote: > > On 2015/06/04 ...
5 years, 6 months ago (2015-06-04 18:47:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159493010/1
5 years, 6 months ago (2015-06-04 18:49:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 19:54:10 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6 Cr-Commit-Position: refs/heads/master@{#332889}
5 years, 6 months ago (2015-06-04 19:55:04 UTC) #10
Nicolas Zea
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1167533007/ by zea@chromium.org. ...
5 years, 6 months ago (2015-06-04 20:24:57 UTC) #11
dshwang
5 years, 6 months ago (2015-06-05 07:54:01 UTC) #12
Message was sent while issue was closed.
On 2015/06/04 20:24:57, Nicolas Zea wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1167533007/ by mailto:zea@chromium.org.
> 
> The reason for reverting is: Broke Linux ChromiumOS compile.
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Sorry for inconvenient. I didn't check unittests. I'll re-submit soon.

Powered by Google App Engine
This is Rietveld 408576698