Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159443002: Roll Dart forward (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
iannucci, eseidel1, siva, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M DEPS View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M sky/engine/bindings/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/tonic/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M sky/shell/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
5 years, 7 months ago (2015-05-22 18:45:27 UTC) #2
eseidel
lgtm YOU'RE BLOWING MY MIND. Dart + GitHub <3
5 years, 7 months ago (2015-05-22 19:14:10 UTC) #4
eseidel
https://codereview.chromium.org/1159443002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1159443002/diff/1/DEPS#newcode43 DEPS:43: 'github.com', I missed this initially. I doubt this is ...
5 years, 7 months ago (2015-05-22 20:21:15 UTC) #6
Cutch
On 2015/05/22 20:21:15, eseidel wrote: > https://codereview.chromium.org/1159443002/diff/1/DEPS > File DEPS (right): > > https://codereview.chromium.org/1159443002/diff/1/DEPS#newcode43 > ...
5 years, 7 months ago (2015-05-22 20:29:03 UTC) #7
Cutch
On 2015/05/22 20:21:15, eseidel wrote: > https://codereview.chromium.org/1159443002/diff/1/DEPS > File DEPS (right): > > https://codereview.chromium.org/1159443002/diff/1/DEPS#newcode43 > ...
5 years, 7 months ago (2015-05-22 20:29:03 UTC) #8
Cutch
5 years, 6 months ago (2015-05-28 14:45:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4613e6be13c55e744f0a68ad4d23f1407f226064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698