Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1159433006: win: Fix current toolchain path with old packaging (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, davidben
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

win: Fix current toolchain path with old packaging I broke boringssl's use of depot_tools toolchain as I changed the name of the sdk path key. This happened to work in Chrome because src/ has fallback behaviour. Restore the 'win8sdk' name when unpacking a current/old-style toolchain package (i.e. what everyone is still using). TBR=dpranke@chromium.org R=davidben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +13 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
scottmg
5 years, 6 months ago (2015-06-02 18:56:56 UTC) #2
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-02 19:00:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159433006/1
5 years, 6 months ago (2015-06-02 19:04:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 19:07:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159433006/1
5 years, 6 months ago (2015-06-02 19:08:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295492
5 years, 6 months ago (2015-06-02 19:12:08 UTC) #12
scottmg
5 years, 6 months ago (2015-06-02 19:37:10 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1167753003/ by scottmg@chromium.org.

The reason for reverting is: Breaking chromium waterfall..

Powered by Google App Engine
This is Rietveld 408576698