src/runtime/runtime-debug.cc - Issue 1159433003: Use GetProperty for getting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 91b6ee5db2d1e78742424458a5c9ab681f2b723a..6612f2c2d5cc1a246274a86f76c1f33e048f346c 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -422,9 +422,8 @@ RUNTIME_FUNCTION(Runtime_DebugIndexedInterceptorElementValue) {

RUNTIME_ASSERT(obj->HasIndexedInterceptor());

CONVERT_NUMBER_CHECKED(uint32_t, index, Uint32, args[1]);

Handle<Object> result;

- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

- isolate, result,

- JSObject::GetElementWithInterceptor(obj, obj, index, true));

+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result,

+ Object::GetElement(isolate, obj, index));

return *result;

}

« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »