src/api.cc - Issue 1159433003: Use GetProperty for getting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 6ecdb4d4a207a2bcc6308d99773d363252456073..73617647c093e0e55e321f4a9a31b7b83d1b75ba 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -6635,7 +6635,7 @@ size_t v8::ArrayBufferView::ByteLength() {

size_t v8::TypedArray::Length() {

i::Handle<i::JSTypedArray> obj = Utils::OpenHandle(this);

- return static_cast<size_t>(obj->length()->Number());

+ return static_cast<size_t>(obj->length_value());

}

« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »