Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 // Return element value from indexed interceptor. 415 // Return element value from indexed interceptor.
416 // args[0]: object 416 // args[0]: object
417 // args[1]: index 417 // args[1]: index
418 RUNTIME_FUNCTION(Runtime_DebugIndexedInterceptorElementValue) { 418 RUNTIME_FUNCTION(Runtime_DebugIndexedInterceptorElementValue) {
419 HandleScope scope(isolate); 419 HandleScope scope(isolate);
420 DCHECK(args.length() == 2); 420 DCHECK(args.length() == 2);
421 CONVERT_ARG_HANDLE_CHECKED(JSObject, obj, 0); 421 CONVERT_ARG_HANDLE_CHECKED(JSObject, obj, 0);
422 RUNTIME_ASSERT(obj->HasIndexedInterceptor()); 422 RUNTIME_ASSERT(obj->HasIndexedInterceptor());
423 CONVERT_NUMBER_CHECKED(uint32_t, index, Uint32, args[1]); 423 CONVERT_NUMBER_CHECKED(uint32_t, index, Uint32, args[1]);
424 Handle<Object> result; 424 Handle<Object> result;
425 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 425 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result,
426 isolate, result, 426 Object::GetElement(isolate, obj, index));
427 JSObject::GetElementWithInterceptor(obj, obj, index, true));
428 return *result; 427 return *result;
429 } 428 }
430 429
431 430
432 RUNTIME_FUNCTION(Runtime_CheckExecutionState) { 431 RUNTIME_FUNCTION(Runtime_CheckExecutionState) {
433 SealHandleScope shs(isolate); 432 SealHandleScope shs(isolate);
434 DCHECK(args.length() == 1); 433 DCHECK(args.length() == 1);
435 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]); 434 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]);
436 RUNTIME_ASSERT(isolate->debug()->CheckExecutionState(break_id)); 435 RUNTIME_ASSERT(isolate->debug()->CheckExecutionState(break_id));
437 return isolate->heap()->true_value(); 436 return isolate->heap()->true_value();
(...skipping 2777 matching lines...) Expand 10 before | Expand all | Expand 10 after
3215 return Smi::FromInt(isolate->debug()->is_active()); 3214 return Smi::FromInt(isolate->debug()->is_active());
3216 } 3215 }
3217 3216
3218 3217
3219 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 3218 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
3220 UNIMPLEMENTED(); 3219 UNIMPLEMENTED();
3221 return NULL; 3220 return NULL;
3222 } 3221 }
3223 } // namespace internal 3222 } // namespace internal
3224 } // namespace v8 3223 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698