Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/array.js

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var $arrayConcat; 5 var $arrayConcat;
6 var $arrayPush; 6 var $arrayPush;
7 var $arrayPop; 7 var $arrayPop;
8 var $arrayShift; 8 var $arrayShift;
9 var $arraySlice; 9 var $arraySlice;
10 var $arraySplice; 10 var $arraySplice;
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 if (key < start_i) { 296 if (key < start_i) {
297 var current = array[key]; 297 var current = array[key];
298 if (!IS_UNDEFINED(current) || key in array) { 298 if (!IS_UNDEFINED(current) || key in array) {
299 new_array[key] = current; 299 new_array[key] = current;
300 } 300 }
301 } else if (key >= start_i + del_count) { 301 } else if (key >= start_i + del_count) {
302 var current = array[key]; 302 var current = array[key];
303 if (!IS_UNDEFINED(current) || key in array) { 303 if (!IS_UNDEFINED(current) || key in array) {
304 var new_key = key - del_count + num_additional_args; 304 var new_key = key - del_count + num_additional_args;
305 new_array[new_key] = current; 305 new_array[new_key] = current;
306 if (new_key > 0xffffffff) { 306 if (new_key > 0xfffffffe) {
307 big_indices = big_indices || new InternalArray(); 307 big_indices = big_indices || new InternalArray();
308 big_indices.push(new_key); 308 big_indices.push(new_key);
309 } 309 }
310 } 310 }
311 } 311 }
312 } 312 }
313 } 313 }
314 } 314 }
315 // Move contents of new_array into this array 315 // Move contents of new_array into this array
316 %MoveArrayContents(new_array, array); 316 %MoveArrayContents(new_array, array);
(...skipping 1350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1667 1667
1668 $arrayConcat = ArrayConcatJS; 1668 $arrayConcat = ArrayConcatJS;
1669 $arrayPush = ArrayPush; 1669 $arrayPush = ArrayPush;
1670 $arrayPop = ArrayPop; 1670 $arrayPop = ArrayPop;
1671 $arrayShift = ArrayShift; 1671 $arrayShift = ArrayShift;
1672 $arraySlice = ArraySlice; 1672 $arraySlice = ArraySlice;
1673 $arraySplice = ArraySplice; 1673 $arraySplice = ArraySplice;
1674 $arrayUnshift = ArrayUnshift; 1674 $arrayUnshift = ArrayUnshift;
1675 1675
1676 }); 1676 });
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698