Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: chrome/browser/ui/webui/flags_ui.cc

Issue 1159433002: Switch nomenclature in about_flags.cc to not use "Experiments". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/flags_ui.cc
diff --git a/chrome/browser/ui/webui/flags_ui.cc b/chrome/browser/ui/webui/flags_ui.cc
index 0918de130310e3c3420d2851daacd83471754bee..6a40e68563df7bc0949bcd6bddec43bd1367191d 100644
--- a/chrome/browser/ui/webui/flags_ui.cc
+++ b/chrome/browser/ui/webui/flags_ui.cc
@@ -174,10 +174,10 @@ void FlagsDOMHandler::HandleRequestFlagsExperiments(
scoped_ptr<base::ListValue> supported_experiments(new base::ListValue);
scoped_ptr<base::ListValue> unsupported_experiments(new base::ListValue);
- about_flags::GetFlagsExperimentsData(flags_storage_.get(),
- access_,
- supported_experiments.get(),
- unsupported_experiments.get());
+ about_flags::GetFlagsEntryData(flags_storage_.get(),
+ access_,
+ supported_experiments.get(),
+ unsupported_experiments.get());
results.Set("supportedExperiments", supported_experiments.release());
results.Set("unsupportedExperiments", unsupported_experiments.release());
results.SetBoolean("needsRestart",
@@ -205,16 +205,14 @@ void FlagsDOMHandler::HandleEnableFlagsExperimentMessage(
if (args->GetSize() != 2)
return;
- std::string experiment_internal_name;
+ std::string entry_internal_name;
std::string enable_str;
- if (!args->GetString(0, &experiment_internal_name) ||
+ if (!args->GetString(0, &entry_internal_name) ||
!args->GetString(1, &enable_str))
return;
- about_flags::SetExperimentEnabled(
- flags_storage_.get(),
- experiment_internal_name,
- enable_str == "true");
+ about_flags::SetEntryEnabled(flags_storage_.get(), entry_internal_name,
+ enable_str == "true");
}
void FlagsDOMHandler::HandleRestartBrowser(const base::ListValue* args) {
« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698