Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: chrome/browser/download/notification/download_notification_item_unittest.cc

Issue 1159363002: [Download Notification] Show preview if downloaded file is image (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & use embedded server Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/notification/download_notification_item_unittest.cc
diff --git a/chrome/browser/download/notification/download_notification_item_unittest.cc b/chrome/browser/download/notification/download_notification_item_unittest.cc
index e59dbeeefea668bc566d4b842e3ea74c61ef2f79..464c1ad3ae253da2426d6bc85dde81ab4ff7b2af 100644
--- a/chrome/browser/download/notification/download_notification_item_unittest.cc
+++ b/chrome/browser/download/notification/download_notification_item_unittest.cc
@@ -23,8 +23,16 @@
using testing::NiceMock;
using testing::Return;
+using testing::ReturnRefOfCopy;
using testing::_;
+namespace {
+
+const base::FilePath::CharType kDownloadItemTargetPathString[] =
+ FILE_PATH_LITERAL("/tmp/TITLE.bin");
+
+} // anonymouse namespace
+
namespace test {
class DownloadNotificationItemTest : public testing::Test {
@@ -49,6 +57,7 @@ class DownloadNotificationItemTest : public testing::Test {
download_notification_manager_.reset(
new DownloadNotificationManagerForProfile(profile_, nullptr));
+ base::FilePath download_item_target_path(kDownloadItemTargetPathString);
download_item_.reset(new NiceMock<content::MockDownloadItem>());
ON_CALL(*download_item_, GetId()).WillByDefault(Return(12345));
ON_CALL(*download_item_, GetState())
@@ -56,6 +65,8 @@ class DownloadNotificationItemTest : public testing::Test {
ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(false));
ON_CALL(*download_item_, GetFileNameToReportUser())
.WillByDefault(Return(base::FilePath("TITLE.bin")));
+ ON_CALL(*download_item_, GetTargetFilePath())
+ .WillByDefault(ReturnRefOfCopy(download_item_target_path));
ON_CALL(*download_item_, GetDangerType())
.WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
ON_CALL(*download_item_, IsDone()).WillByDefault(Return(false));
« no previous file with comments | « chrome/browser/download/notification/download_notification_item.cc ('k') | chrome/test/data/downloads/image-octet-stream.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698