chrome/browser/image_decoder_browsertest.cc - Issue 1159363002: [Download Notification] Show preview if downloaded file is image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/image_decoder_browsertest.cc

Issue 1159363002: [Download Notification] Show preview if downloaded file is image (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments #12 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/notification/download_notification_browsertest.cc ('K') | « chrome/browser/image_decoder.cc ('k') | chrome/common/chrome_utility_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/image_decoder_browsertest.cc

diff --git a/chrome/browser/image_decoder_browsertest.cc b/chrome/browser/image_decoder_browsertest.cc

index d9350dec04185956e39e6e47be7b933875b653ed..9095bb6e8b8b64660a5cca06291d7a67e04b94f3 100644

--- a/chrome/browser/image_decoder_browsertest.cc

+++ b/chrome/browser/image_decoder_browsertest.cc

@@ -146,6 +146,18 @@ IN_PROC_BROWSER_TEST_F(ImageDecoderBrowserTest, BasicDecode) {

EXPECT_TRUE(test_request.decode_succeeded());

}

+IN_PROC_BROWSER_TEST_F(ImageDecoderBrowserTest, BasicDecodeFile) {

+ scoped_refptr<content::MessageLoopRunner> runner =

+ new content::MessageLoopRunner;

+ TestImageRequest test_request(runner->QuitClosure());

+ ImageDecoder::StartByFilePath(

+ &test_request,

+ base::FilePath(

+ FILE_PATH_LITERAL("chrome/test/data/image_decoding/droids.jpg")));

+ runner->Run();

+ EXPECT_TRUE(test_request.decode_succeeded());

IN_PROC_BROWSER_TEST_F(ImageDecoderBrowserTest, StartAndDestroy) {

scoped_refptr<content::MessageLoopRunner> runner =

new content::MessageLoopRunner;