[Download Notification] Show preview if downloaded file is image

chrome/browser/download/notification/download_notification_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
@@ skipping 483 matching lines @@
   // Checks there is neither any download nor any notification.
   EXPECT_EQ(0u, GetMessageCenter()->GetVisibleNotifications().size());
   std::vector<content::DownloadItem*> downloads;
   GetDownloadManager(browser())->GetAllDownloads(&downloads);
   EXPECT_EQ(0u, downloads.size());
 
   // Checks the downloaded file doesn't exist.
   EXPECT_FALSE(base::PathExists(GetDownloadPath().Append(filename.BaseName())));
 }
 
+IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadImageFile) {
+  ASSERT_TRUE(test_server()->Start());

[asanka, 2015/06/17 14:35:30]

Didn't you migrate this test suite to use embedded_test_server()? Rebase/merge?

[yoshiki, 2015/06/18 10:48:04]

Done.

+  GURL download_url(
+      test_server()->GetURL("files/downloads/image-octet-stream.png"));
+
+  content::DownloadTestObserverTerminal download_terminal_observer(
+      GetDownloadManager(browser()),
+      1u,  /* wait_count */
+      content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_IGNORE);
+
+  CreateDownloadForBrowserAndURL(browser(), download_url);
+
+  // Wait for the download completion.
+  download_terminal_observer.WaitForFinished();
+
+  // Waits for download completion.
+  while (GetNotification(notification_id())->image().IsEmpty()) {
+    NotificationUpdateObserver download_change_notification_observer;
+    download_change_notification_observer.Wait();
+  }
+}
+
 IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
                        CloseNotificationAfterDownload) {
   CreateDownload();
 
   // Requests to complete the download.
   ui_test_utils::NavigateToURL(
       browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));
 
   // Waits for download completion.
   while (download_item()->GetState() != content::DownloadItem::COMPLETE) {
@@ skipping 530 matching lines @@
   }
 
   // Confirms the types of download notifications are correct.
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id1)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id2)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id3)->type());
 }