[Download Notification] Show preview if downloaded file is image

chrome/browser/download/notification/download_notification_item_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/notification/download_notification_item.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/message_center/fake_message_center.h"
 
 using testing::NiceMock;
 using testing::Return;
+using testing::ReturnRef;
 using testing::_;
 
 namespace {
 
 class MockDownloadNotificationItemDelegate
     : public DownloadNotificationItem::Delegate {
  public:
   MockDownloadNotificationItemDelegate()
       : on_download_removed_call_count_(0u),
         on_download_started_call_count_(0u),
@@ skipping 25 matching lines @@
   size_t GetOnDownloadStoppedCallCount() {
     return on_download_stopped_call_count_;
   }
 
  private:
   size_t on_download_removed_call_count_;
   size_t on_download_started_call_count_;
   size_t on_download_stopped_call_count_;
 };
 
+const base::FilePath::StringType

[Lei Zhang, 2015/06/15 21:30:58]

Err, sorry, I gave incorrect advice. The preprocessor would turn this into:

const std::string kDownloadItemTargetPathString = "/tmp/TITLE.bin";

and that's still not POD. What you need is:

const base::FilePath::CharType kDownloadItemTargetPathString[] =
FILE_PATH_LITERAL("/tmp/TITLE.bin");

This is documented in base/files/file_path.h, line 58.

I also suspect the code, as is, may not build on Windows. I kicked off a win
trybot.

+    kDownloadItemTargetPathString = "/tmp/TITLE.bin";
+
 }  // anonymous namespace
 
 namespace test {
 
 class DownloadNotificationItemTest : public testing::Test {
  public:
   DownloadNotificationItemTest()
       : ui_thread_(content::BrowserThread::UI, &message_loop_),
         profile_(nullptr) {}
 
   void SetUp() override {
     testing::Test::SetUp();
     message_center::MessageCenter::Initialize();
 
     profile_manager_.reset(
         new TestingProfileManager(TestingBrowserProcess::GetGlobal()));
     ASSERT_TRUE(profile_manager_->SetUp());
     profile_ = profile_manager_->CreateTestingProfile("test-user");
 
     ui_manager_.reset(new StubNotificationUIManager);
     DownloadNotificationItem::SetStubNotificationUIManagerForTesting(
         ui_manager_.get());
 
+    base::FilePath download_item_target_path(kDownloadItemTargetPathString);
     download_item_.reset(new NiceMock<content::MockDownloadItem>());
     ON_CALL(*download_item_, GetId()).WillByDefault(Return(12345));
     ON_CALL(*download_item_, GetState())
         .WillByDefault(Return(content::DownloadItem::IN_PROGRESS));
     ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(false));
     ON_CALL(*download_item_, GetFileNameToReportUser())
         .WillByDefault(Return(base::FilePath("TITLE.bin")));
+    ON_CALL(*download_item_, GetTargetFilePath())
+        .WillByDefault(ReturnRef(download_item_target_path));
     ON_CALL(*download_item_, GetDangerType())
         .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
     ON_CALL(*download_item_, IsDone()).WillByDefault(Return(false));
   }
 
   void TearDown() override {
     download_notification_item_.reset();
     profile_manager_.reset();
     message_center::MessageCenter::Shutdown();
     testing::Test::TearDown();
@@ skipping 179 matching lines @@
 
   // Checks OnDownloadRemoved().
   EXPECT_EQ(0u, delegate_.GetOnDownloadRemovedCallCount());
   download_item_->NotifyObserversDownloadRemoved();
   EXPECT_EQ(1u, delegate_.GetOnDownloadRemovedCallCount());
 
   download_item_.reset();
 }
 
 }  // namespace test