[Download Notification] Show preview if downloaded file is image

chrome/browser/image_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IMAGE_DECODER_H_
 #define CHROME_BROWSER_IMAGE_DECODER_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
+#include "base/files/file.h"
 #include "base/lazy_instance.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequence_checker.h"
 #include "base/sequenced_task_runner.h"
 #include "base/synchronization/lock.h"
 #include "base/timer/timer.h"
 #include "content/public/browser/utility_process_host.h"
 #include "content/public/browser/utility_process_host_client.h"
 
 class SkBitmap;
@@ skipping 42 matching lines @@
     base::SequenceChecker sequence_checker_;
   };
 
   enum ImageCodec {
     DEFAULT_CODEC = 0,  // Uses WebKit image decoding (via WebImage).
 #if defined(OS_CHROMEOS)
     ROBUST_JPEG_CODEC,  // Restrict decoding to robust jpeg codec.
 #endif  // defined(OS_CHROMEOS)
   };
 
+  static void Start(ImageRequest* image_request,
+                    const base::FilePath& image_file_path);
+
   // Calls StartWithOptions() with ImageCodec::DEFAULT_CODEC and
   // shrink_to_fit = false.
   static void Start(ImageRequest* image_request,
                     const std::string& image_data);
 
   // Starts asynchronous image decoding. Once finished, the callback will be
   // posted back to image_request's |task_runner_|.
   static void StartWithOptions(ImageRequest* image_request,
                                const std::string& image_data,
                                ImageCodec image_codec,
                                bool shrink_to_fit);
 
   // Removes all instances of |image_request| from |image_request_id_map_|,
   // ensuring callbacks are not made to the image_request after it is destroyed.
   static void Cancel(ImageRequest* image_request);
 
  private:
   friend struct base::DefaultLazyInstanceTraits<ImageDecoder>;
 
   using RequestMap = std::map<int, ImageRequest*>;
 
   ImageDecoder();
   // It's a reference counted object, so destructor is private.
   ~ImageDecoder() override;
 
   // Sends a request to the sandboxed process to decode the image. Starts
   // batch mode if necessary. If the utility process fails to start,
   // an OnDecodeImageFailed task is posted to image_request's |task_runner_|.
   void DecodeImageInSandbox(int request_id,

[asanka, 2015/06/11 03:30:52]

I'll defer to the owners.

However, for both DecodeImageInSandbox() and StartWithOptionsImpl() different
subsets of parameters are valid. It's probably a good sign that these should be
split.

[yoshiki, 2015/06/11 08:22:09]

Acknowledged.

+                            base::File image_file,
                             const std::vector<unsigned char>& image_data,
                             ImageCodec image_codec,
                             bool shrink_to_fit);
 
   void StartWithOptionsImpl(ImageRequest* image_request,
+                            const base::FilePath& image_file_path,
                             const std::string& image_data,
                             ImageCodec image_codec,
                             bool shrink_to_fit);
   void CancelImpl(ImageRequest* image_request);
 
   // Starts UtilityProcessHost in batch mode and starts |batch_mode_timer_|.
   // If the utility process fails to start, the method resets
   // |utility_process_host_| and returns.
   void StartBatchMode();
 
@@ skipping 31 matching lines @@
   base::WeakPtr<content::UtilityProcessHost> utility_process_host_;
 
   // Calls StopBatchMode() after |kBatchModeTimeoutSeconds| have elapsed,
   // unless a new decoding request resets the timer.
   scoped_ptr<base::DelayTimer<ImageDecoder>> batch_mode_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(ImageDecoder);
 };
 
 #endif  // CHROME_BROWSER_IMAGE_DECODER_H_