Index: components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java |
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java |
index 80f2df81ea9d5b9e833995eeee3a9fa67969ffef..616c52589024d3a95461145128a4b66ed8110c32 100644 |
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java |
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java |
@@ -35,6 +35,23 @@ public abstract class UrlRequestContext { |
UrlRequestListener listener, Executor executor); |
/** |
+ * Creates an UrlRequest object. All UrlRequest functions must |
xunjieli
2015/06/05 15:02:51
nit: a UrlRequest. Please also surround it with {@
mkirsche
2015/06/05 15:12:21
Done.
|
+ * be called on the Executor's thread, and all callbacks will be called |
xunjieli
2015/06/05 15:02:51
Since you are here, could you remove "All UrlReque
mkirsche
2015/06/05 15:12:21
Done.
|
+ * on the Executor's thread as well. Executor must not run tasks on the |
+ * current thread to prevent network jank and exception during shutdown. |
+ * |
+ * createRequest itself may be called on any thread. |
xunjieli
2015/06/05 15:02:51
Could you remove "createRequest itself may be call
mkirsche
2015/06/05 15:12:21
Done.
|
+ * @param url URL for the request. |
+ * @param listener Callback interface that gets called on different events. |
+ * @param executor Executor on which all callbacks will be called. |
+ * @param priority Priority of the request - should be one of the |
xunjieli
2015/06/05 15:02:51
Why is there a dash here?
mkirsche
2015/06/05 15:12:21
Done.
|
+ REQUEST_PRIORITY_* values in UrlRequest.java |
+ * @return new request. |
+ */ |
+ public abstract UrlRequest createRequest(String url, |
+ UrlRequestListener listener, Executor executor, int priority); |
+ |
+ /** |
* @return true if the context is enabled. |
*/ |
public abstract boolean isEnabled(); |