Expose Cronet Url requests with priorities.

At present there are priorities implemented but they are not exposed.
Add the ability to create a CronetUrlRequest with a priority.
BUG=

Committed: https://crrev.com/2720fcd53f14ae6e7d4ec65a988729c6ae889236
Cr-Commit-Position: refs/heads/master@{#333059}

[mkirsche, 2015-06-04 16:05:20]

mkirsche@google.com changed reviewers:
+ miloslav@google.com

[mkirsche, 2015-06-05 14:18:49]

mkirsche@google.com changed reviewers:
+ xunjieli@chromium.org

[xunjieli, 2015-06-05 14:43:29]

Could you add an abstract method with the same signature to
UrlRequestContext.java? Please also note in the javadoc (for the abstract
method) that the priority argument should be one of REQUEST_PRIORITY_* values in
UrlRequest.java?

[mkirsche, 2015-06-05 14:51:44]

On 2015/06/05 14:43:29, xunjieli wrote:
> Could you add an abstract method with the same signature to
> UrlRequestContext.java? Please also note in the javadoc (for the abstract
> method) that the priority argument should be one of REQUEST_PRIORITY_* values
in
> UrlRequest.java?

Done.

[xunjieli, 2015-06-05 15:02:51]

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:85:
public UrlRequest createRequest(String url, UrlRequestListener listener,
@Override.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
File components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:38: *
Creates an UrlRequest object. All UrlRequest functions must
nit: a UrlRequest. Please also surround it with {@link}.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:39: *
be called on the Executor's thread, and all callbacks will be called
Since you are here, could you remove "All UrlRequest functions must be called on
the Executor's thread, and"? That part is misleading. Please also edit the
javadoc for the other method.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:43: *
createRequest itself may be called on any thread.
Could you remove "createRequest itself may be called on any thread."? That's
redundant once we remove the part above.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:47: *
@param priority Priority of the request - should be one of the
Why is there a dash here?

[mkirsche, 2015-06-05 15:12:22]

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:85:
public UrlRequest createRequest(String url, UrlRequestListener listener,
On 2015/06/05 15:02:51, xunjieli wrote:
> @Override.

Done.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
File components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:38: *
Creates an UrlRequest object. All UrlRequest functions must
On 2015/06/05 15:02:51, xunjieli wrote:
> nit: a UrlRequest. Please also surround it with {@link}.

Done.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:39: *
be called on the Executor's thread, and all callbacks will be called
On 2015/06/05 15:02:51, xunjieli wrote:
> Since you are here, could you remove "All UrlRequest functions must be called
on
> the Executor's thread, and"? That part is misleading. Please also edit the
> javadoc for the other method.

Done.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:43: *
createRequest itself may be called on any thread.
On 2015/06/05 15:02:51, xunjieli wrote:
> Could you remove "createRequest itself may be called on any thread."? That's
> redundant once we remove the part above.

Done.

https://codereview.chromium.org/1159343003/diff/60001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:47: *
@param priority Priority of the request - should be one of the
On 2015/06/05 15:02:51, xunjieli wrote:
> Why is there a dash here?

Done.

[xunjieli, 2015-06-05 15:17:30]

Did you forget to upload your new patch?

[mkirsche, 2015-06-05 15:18:42]

On 2015/06/05 15:17:30, xunjieli wrote:
> Did you forget to upload your new patch?

Yes I did - sorry about that!

[xunjieli, 2015-06-05 15:29:50]

Btw, we don't have a Cronet trybot right now, so "git cl try" won't build Cronet
and run tests. Could you run the tests locally by doing
"components/cronet/tools/cr_cronet.py test" in
https://sites.google.com/a/google.com/cronet/docs/build-instructions?

I will sign off if you address my comments below and run tests locally.

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
File components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:36: *
Creates a {@link org.chromium.net.UrlRequest} object. All callbacks will
nit: I think if we are refering to the class in the same package, the prefix can
be omitted, so this can be "{@link UrlRequest}". (x2)

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:44:
REQUEST_PRIORITY_* values in UrlRequest.java
nit: Use "{@link UrlRequest}"

[mkirsche, 2015-06-05 15:43:55]

Worked on tests

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
File components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:36: *
Creates a {@link org.chromium.net.UrlRequest} object. All callbacks will
On 2015/06/05 15:29:50, xunjieli wrote:
> nit: I think if we are refering to the class in the same package, the prefix
can
> be omitted, so this can be "{@link UrlRequest}". (x2)

Done.

https://codereview.chromium.org/1159343003/diff/100001/components/cronet/andr...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:44:
REQUEST_PRIORITY_* values in UrlRequest.java
On 2015/06/05 15:29:50, xunjieli wrote:
> nit: Use "{@link UrlRequest}"

Done.

[xunjieli, 2015-06-05 15:47:11]

LGTM assuming you would address one more comment below.

https://codereview.chromium.org/1159343003/diff/120001/components/cronet/andr...
File components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java
(right):

https://codereview.chromium.org/1159343003/diff/120001/components/cronet/andr...
components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java:44:
REQUEST_PRIORITY_* values in {@link UrlRequest}
nit: please put a period at the end.

[mkirsche, 2015-06-05 15:48:52]

The CQ bit was checked by mkirsche@google.com

[mkirsche, 2015-06-05 15:48:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1159343003/#ps140001
(title: "Added period")

[commit-bot: I haz the power, 2015-06-05 15:50:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1159343003/140001

[commit-bot: I haz the power, 2015-06-05 16:12:40]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-06-05 16:13:32]

Patchset 8 (id:??) landed as
https://crrev.com/2720fcd53f14ae6e7d4ec65a988729c6ae889236
Cr-Commit-Position: refs/heads/master@{#333059}