Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159343002: Fix tests to run on 32 bits. (Closed)

Created:
5 years, 6 months ago by iannucci
Modified:
5 years, 6 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M go/src/infra/gae/libs/wrapper/memory/datastore_test.go View 3 chunks +12 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 6 months ago (2015-06-01 02:10:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159343002/1
5 years, 6 months ago (2015-06-01 02:10:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/b8a79c43b4a45e19ab7a217f86e8678ab878ba49
5 years, 6 months ago (2015-06-01 02:12:45 UTC) #4
M-A Ruel
lgtm but with better comment. https://codereview.chromium.org/1159343002/diff/1/go/src/infra/gae/libs/wrapper/memory/datastore_test.go File go/src/infra/gae/libs/wrapper/memory/datastore_test.go (right): https://codereview.chromium.org/1159343002/diff/1/go/src/infra/gae/libs/wrapper/memory/datastore_test.go#newcode601 go/src/infra/gae/libs/wrapper/memory/datastore_test.go:601: // this is supremely ...
5 years, 6 months ago (2015-06-01 13:08:20 UTC) #5
iannucci
5 years, 6 months ago (2015-06-01 17:36:17 UTC) #6
Message was sent while issue was closed. 
On 2015/06/01 13:08:20, M-A Ruel wrote:
> lgtm but with better comment.
> 
>
https://codereview.chromium.org/1159343002/diff/1/go/src/infra/gae/libs/wrapp...
> File go/src/infra/gae/libs/wrapper/memory/datastore_test.go (right):
> 
>
https://codereview.chromium.org/1159343002/diff/1/go/src/infra/gae/libs/wrapp...
> go/src/infra/gae/libs/wrapper/memory/datastore_test.go:601: // this is
supremely
> stupid. The SDK uses 'int' which measn we have to
> means
> 
>
https://codereview.chromium.org/1159343002/diff/1/go/src/infra/gae/libs/wrapp...
> go/src/infra/gae/libs/wrapper/memory/datastore_test.go:602: // use it too, but
> then THEY BOUNDS CHECK IT FOR 32 BITS... *sigh*
> bah, 2 millions items is large. it's probably more a limitation of the query
> system underneath, I wouldn't say this is stupid.

Yeah, but... I mean...use int16 or int32 or something... I'm still annoyed at
it... maybe next week I'll revise it later :p.

Powered by Google App Engine
This is Rietveld 408576698