Add BUILD.gn for third_party/freetype

Add BUILD.gn for third_party/freetype

This is the same as the existing BUILD.gn found in chromium's
src/build/secondary/third_party/freetype/BUILD.gn except it adds
the missing ftmm.c. Moving this file here will make it more obvious
that this file needs to be updated in step with the other build
files for this project.

[bungeman-chromium, 2015-06-02 18:03:29]

bungeman@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[bungeman-chromium, 2015-06-02 18:03:30]

After this lands the roll to include it into Chromium can remove the current
src/build/secondary/third_party/freetype/BUILD.gn file.

[bungeman-chromium, 2015-06-02 18:12:52]

bungeman@chromium.org changed reviewers:
+ michaelbai@chromium.org

[Xianzhu, 2015-06-02 18:38:45]

wangxianzhu@chromium.org changed reviewers:
+ brettw@chromium.org

[Xianzhu, 2015-06-02 18:38:46]

Do you know why the gn file was under build/secondary?

Please also update third_party/freetype/README.chromium about BUILD.gn (besides
comments about freetype.gyp).

https://codereview.chromium.org/1159323004/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1159323004/diff/1/BUILD.gn#newcode44
BUILD.gn:44: include_dirs = [ "build" ]
There seems an error in freetype.gyp about 'build' which should be 'builds'.
However because we never used the include dir, I think we can remove this rule
(as well as the rule in freetype.gyp).

[bungeman-chromium, 2015-06-02 19:10:24]

I imagine this was in build/secondary for expediency while adding the gn build
files. It seems like it should be a good idea to eventually be able to remove
everything from there.

https://codereview.chromium.org/1159323004/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1159323004/diff/1/BUILD.gn#newcode44
BUILD.gn:44: include_dirs = [ "build" ]
On 2015/06/02 18:38:46, Xianzhu wrote:
> There seems an error in freetype.gyp about 'build' which should be 'builds'.
> However because we never used the include dir, I think we can remove this rule
> (as well as the rule in freetype.gyp).

hmmm... yes I had wondered about that. Apparently the one include in the
'builds' directory is designed around installing, which we never do. I'll remove
it.

[brettw, 2015-06-02 19:30:54]

The history of the build/secondary is correct.

Our of curiosity, why do we have freetype in a separate repo? This generally
makes more work for people for little benefit.

An example is if I change something in GN and need to update the build files.
Now the issue becomes tracking down the repo and rolling deps which is a lot
harder.

[bungeman-chromium, 2015-06-02 19:40:14]

On 2015/06/02 19:30:54, brettw wrote:
> The history of the build/secondary is correct.
> 
> Our of curiosity, why do we have freetype in a separate repo? This generally
> makes more work for people for little benefit.
> 
> An example is if I change something in GN and need to update the build files.
> Now the issue becomes tracking down the repo and rolling deps which is a lot
> harder.

I generally agree, if I were setting this up the DEPS would checkout the aosp
freetype into a subdirectory, leaving the top level third_party/freetype
directory in the chromium repo with the chromium build files there (as many
other third_party repos are managed). It would probably be a great idea to
re-organize this that way. There's currently some debate about which freetype
this should be in the future as well, so things are somewhat in flux at the
moment. All I really wanted to do starting out was add ftmm.c to the build :-)
Part of the reason why this isn't just in chromium's repo to begin with is that
this is Chromium for Android specific.

[Xianzhu, 2015-06-02 19:47:49]

On 2015/06/02 19:30:54, brettw wrote:
> The history of the build/secondary is correct.
> 
> Our of curiosity, why do we have freetype in a separate repo? This generally
> makes more work for people for little benefit.
> 
> An example is if I change something in GN and need to update the build files.
> Now the issue becomes tracking down the repo and rolling deps which is a lot
> harder.

I think it would be good to combine third_party/freetype into the main repo.

Currently we still the following (not strong though) reasons to keep the
separate repo:
- the repo is checked out only when OS=android (would be a non-issue if we
decide to combine third_party/freetype and third_party/freetype2);
- we haven't decided yet whether to continue to copy Android's
external/freetype, mirror Android's external/freetype, or copy from
freetype.org.

[brettw, 2015-06-02 19:58:57]

This patch LGTM. Please consider moving into the main repo, I think it is small
enough so that it doesn't matter (looks like 10MB?). Also, the infrastructure
should be in a state where this type of move can be done painlessly.

[Xianzhu, 2015-06-02 20:22:15]

lgtm

https://codereview.chromium.org/1159323004/diff/20001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/1159323004/diff/20001/README.chromium#newcode25
README.chromium:25: 5. Update freetype.gyp to reflect any changes made in
Android.mk.
Also update this sentence.

[bungeman-chromium, 2015-06-02 21:25:15]

https://codereview.chromium.org/1159323004/diff/20001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/1159323004/diff/20001/README.chromium#newcode25
README.chromium:25: 5. Update freetype.gyp to reflect any changes made in
Android.mk.
On 2015/06/02 20:22:15, Xianzhu wrote:
> Also update this sentence.

Done.

[bungeman-chromium, 2015-06-04 15:31:54]

Closing in favor of https://codereview.chromium.org/1155743013/ .