Issue 11593028: Object.observe: Change semantics of deliverChangeRecords to iterate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11593028: Object.observe: Change semantics of deliverChangeRecords to iterate. (Closed)

Created:
8 years ago by rossberg

Modified:
8 years ago

Reviewers:
Yang

CC:
v8-dev, adamk, arv (Not doing code reviews), rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Object.observe: Change semantics of deliverChangeRecords to iterate. Added test for recursive change generation. R=yangguo@chromium.org BUG=v8:2409 Committed: http://code.google.com/p/v8/source/detail?r=13239

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -37 lines)			Patch
	M	src/object-observe.js	View	1	6 chunks	+14 lines, -30 lines	0 comments	Download
		test/mjsunit/harmony/object-observe.js	View	1	20 chunks	+54 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years ago (2012-12-19 09:37:06 UTC) #3

Oh right. I had some comments.

https://codereview.chromium.org/11593028/diff/1/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/11593028/diff/1/src/object-observe.js#newcode200
src/object-observe.js:200: return false;
This formatting looks very WebKit-ish. We usually have the if-body either on the
same line or inside brackets.

https://codereview.chromium.org/11593028/diff/1/src/object-observe.js#newcode204
src/object-observe.js:204: return false;
Ditto.

Expand Messages | Collapse Messages