Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11593008: Enable the "skip command compilation if output is already up-to-date" feature in dart2dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/skipping_dart2js_compilations_test.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 335766a1bc63f1f59a1bd9726241f09026991a86..e160e5ef753db6f2bdd84dd7041fd22a367464d5 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -51,16 +51,16 @@ class Command {
Future<bool> get outputIsUpToDate => new Future.immediate(false);
}
-class Dart2JsCommand extends Command {
- String _jsOutputFile;
+class CompilationCommand extends Command {
+ String _outputFile;
bool _neverSkipCompilation;
List<Uri> _bootstrapDependencies;
- Dart2JsCommand(this._jsOutputFile,
- this._neverSkipCompilation,
- this._bootstrapDependencies,
- String executable,
- List<String> arguments)
+ CompilationCommand(this._outputFile,
+ this._neverSkipCompilation,
+ this._bootstrapDependencies,
+ String executable,
+ List<String> arguments)
: super(executable, arguments);
Future<bool> get outputIsUpToDate {
@@ -83,11 +83,11 @@ class Dart2JsCommand extends Command {
});
}
- return readDepsFile("$_jsOutputFile.deps").transform((dependencies) {
+ return readDepsFile("$_outputFile.deps").transform((dependencies) {
if (dependencies != null) {
dependencies.addAll(_bootstrapDependencies);
var jsOutputLastModified = TestUtils.lastModifiedCache.getLastModified(
- new Uri.fromComponents(scheme: 'file', path: _jsOutputFile));
+ new Uri.fromComponents(scheme: 'file', path: _outputFile));
if (jsOutputLastModified != null) {
for (var dependency in dependencies) {
var dependencyLastModified =
« no previous file with comments | « tests/standalone/io/skipping_dart2js_compilations_test.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698